fix: reference correct secret parts in errors

[wass3r]

fixes go-vela/community#387

When we call .ParseOrg, we pass in the current repo's information (eg. https://github.com/go-vela/pkg-executor/blob/57b690402cf77554746eebe9e870ae7a3ec1e37d/executor/linux/secret.go#L196 - passing in current repo's org).

When a user provides a secret from a different org via the key property, the error prints the current org the user is trying to use the secret from instead of the org that they are referencing in the key.

for example:

Assuming the following pipeline is used in github.com/go-vela/test:

version: "1"

steps:
  - name: test
    image: alpine:latest
    pull: true
    command:
      - echo hi

secrets:
  - name: org-secret
    key: wass3r/secret
    type: org
    engine: native

The error would print:

error:invalid organization in key: go-vela

instead of:

error:invalid organization in key: wass3r

[codecov]

Codecov Report

Merging #198 (333e09e) into master (e71f8bc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          53       53           
  Lines        5462     5462           
=======================================
  Hits         5297     5297           
  Misses        119      119           
  Partials       46       46           

Impacted Files	Coverage Δ
pipeline/secret.go	90.10% <100.00%> (ø)

[wass3r]

one thought.. should we print the whole supplied key value instead?

[jbrockopp]

LGTM

[matt-fevold]

LGTM

[matt-fevold]

one thought.. should we print the whole supplied key value instead?

Not sure 🤔 I think what you've got already should help reduce confusion a lot.