Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add comment support for ruleset #47

Merged
merged 2 commits into from
Apr 8, 2020
Merged

feat: add comment support for ruleset #47

merged 2 commits into from
Apr 8, 2020

Conversation

kneal
Copy link

@kneal kneal commented Apr 6, 2020

No description provided.

@kneal kneal added the feature Indicates a new feature label Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #47 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         2294      2315   +21     
=========================================
+ Hits          2294      2315   +21
Impacted Files Coverage Δ
database/repo.go 100.00% <100.00%> (ø)
library/repo.go 100.00% <100.00%> (ø)
library/secret.go 100.00% <100.00%> (ø)
pipeline/ruleset.go 100.00% <100.00%> (ø)
yaml/ruleset.go 100.00% <100.00%> (ø)

@kneal kneal marked this pull request as ready for review April 6, 2020 20:15
@kneal kneal requested a review from a team as a code owner April 6, 2020 20:15
jbrockopp
jbrockopp previously approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbrockopp
jbrockopp approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockopp jbrockopp merged commit 5750ec2 into master Apr 8, 2020
@jbrockopp jbrockopp deleted the feat/comments branch April 8, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockopp jbrockopp jbrockopp approved these changes

@wass3r wass3r wass3r approved these changes

Assignees

@kneal kneal

@KellyMerrick KellyMerrick

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kneal @wass3r @jbrockopp @KellyMerrick