Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(yaml): refactor for table tests #68

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

jbrockopp
Copy link
Contributor

This will refactor all tests in the go-vela/types/yaml package to use table tests.

More information: https://github.com/golang/go/wiki/TableDrivenTests

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label May 12, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner May 12, 2020 14:54
@jbrockopp jbrockopp self-assigned this May 12, 2020
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         2625      2625           
=========================================
  Hits          2625      2625           

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3r wass3r merged commit 118a4d1 into master May 13, 2020
@wass3r wass3r deleted the test/yaml/table_tests branch May 13, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants