Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci/lint): consistent linter setup #179

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

wass3rw3rk
Copy link
Member

to match go-vela/server

to match go-vela/server
@wass3rw3rk wass3rw3rk requested a review from a team as a code owner August 26, 2024 16:55
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.71%. Comparing base (d28fd20) to head (b7708f0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   36.71%   36.71%           
=======================================
  Files          11       11           
  Lines         700      700           
=======================================
  Hits          257      257           
  Misses        425      425           
  Partials       18       18           
Files Coverage Δ
cmd/vela-artifactory/config.go 70.96% <ø> (ø)
cmd/vela-artifactory/copy.go 100.00% <ø> (ø)
cmd/vela-artifactory/delete.go 88.88% <ø> (ø)
cmd/vela-artifactory/main.go 0.00% <ø> (ø)
cmd/vela-artifactory/prop.go 96.36% <ø> (ø)
cmd/vela-artifactory/upload.go 100.00% <ø> (ø)
version/version.go 0.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3r wass3r self-assigned this Aug 27, 2024
@wass3r wass3r requested review from plyr4 and ecrupper August 27, 2024 16:06
@wass3rw3rk wass3rw3rk merged commit ebef58b into main Aug 28, 2024
11 of 12 checks passed
@wass3rw3rk wass3rw3rk deleted the fix/lint/consistency branch August 28, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants