Use v3 branch for pushes and feature branch for PRs for code coverage #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+15
to
+20
| - name: Set ref for PR | ||
| if: github.event_name == 'pull_request' | ||
| run: echo "REF=${{ github.head_ref }}" >> $GITHUB_ENV | ||
| - name: Set ref for Push | ||
| if: github.event_name == 'push' | ||
| run: echo "REF=${{ github.ref }}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Is there a reason to prefer this over specifying something like ref: ${{ github.head_ref || github.ref }} in the checkout action?
raphael
added a commit
that referenced
this pull request
Jan 23, 2024
|
My understanding is that |
raphael
added a commit
that referenced
this pull request
Jan 23, 2024
* Move templates out of Go code into their own files This makes the code clearer, avoids the ability to abuse templates (e.g. via string interpolation) and makes debugging template errors easier. * Make readTemplates work on Windows * Skip flaky tests (#3458) Prevent random test failures during CI with the error message: listen udp 127.0.0.1:62112: bind: An attempt was made to access a socket in a way forbidden by its access permissions. Re-running tests fixes it but testing on Linux is enough anyway for these tests. * No need to checkout to report test coverage (#3459) * Use v3 branch for pushes, and feature branch for PRs when pushing code coverage (#3460) * Use testify to simplify tests * Move to testify * Make tests work on Windows
|
The approach above didn't work... I updated it in #3463 - hard to test this stuff without merging first unfortunately. |
|
Ah, gotcha. I can never keep clear exactly which of those are available when. 👍 And agreed testing them is a bear. It's almost like they expect you to create throw-away projects, or a mess in your history. |
|
It's still not working properly ugh... |
ti-chi-bot bot
referenced
this pull request
in PingCAP-QE/ee-apps
Apr 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [goa.design/goa/v3](https://togithub.com/goadesign/goa) | `v3.14.1` -> `v3.16.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>goadesign/goa (goa.design/goa/v3)</summary> ### [`v3.16.1`](https://togithub.com/goadesign/goa/releases/tag/v3.16.1) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.16.0...v3.16.1) #### What's Changed - Save r.URL.Query() in a variable by [@​duckbrain](https://togithub.com/duckbrain) in [https://github.com/goadesign/goa/pull/3506](https://togithub.com/goadesign/goa/pull/3506) - chore: fix function names in comment by [@​goodfirm](https://togithub.com/goodfirm) in [https://github.com/goadesign/goa/pull/3504](https://togithub.com/goadesign/goa/pull/3504) - go fmt ./... by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3507](https://togithub.com/goadesign/goa/pull/3507) - Fix handling of custom gen packages by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3508](https://togithub.com/goadesign/goa/pull/3508) #### New Contributors - [@​duckbrain](https://togithub.com/duckbrain) made their first contribution in [https://github.com/goadesign/goa/pull/3506](https://togithub.com/goadesign/goa/pull/3506) - [@​goodfirm](https://togithub.com/goodfirm) made their first contribution in [https://github.com/goadesign/goa/pull/3504](https://togithub.com/goadesign/goa/pull/3504) **Full Changelog**: goadesign/goa@v3.16.0...v3.16.1 ### [`v3.16.0`](https://togithub.com/goadesign/goa/releases/tag/v3.16.0) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.15.2...v3.16.0) #### What's Changed - Add OpenAPI deprecated support to DSL. by [@​xlanor](https://togithub.com/xlanor) in [https://github.com/goadesign/goa/pull/3497](https://togithub.com/goadesign/goa/pull/3497) - Customize proto message name by [@​nitinmohan87](https://togithub.com/nitinmohan87) in [https://github.com/goadesign/goa/pull/3498](https://togithub.com/goadesign/goa/pull/3498) - Fix eval.IncompatibleDSL() to hide internal DSL by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3502](https://togithub.com/goadesign/goa/pull/3502) #### New Contributors - [@​xlanor](https://togithub.com/xlanor) made their first contribution in [https://github.com/goadesign/goa/pull/3497](https://togithub.com/goadesign/goa/pull/3497) **Full Changelog**: goadesign/goa@v3.15.2...v3.16.0 ### [`v3.15.2`](https://togithub.com/goadesign/goa/releases/tag/v3.15.2) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.15.1...v3.15.2) #### What's Changed - Rename to codegen/service/templates/security_authfuncs.go.tpl by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3496](https://togithub.com/goadesign/goa/pull/3496) **Full Changelog**: goadesign/goa@v3.15.1...v3.15.2 ### [`v3.15.1`](https://togithub.com/goadesign/goa/releases/tag/v3.15.1) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.15.0...v3.15.1) #### What's Changed - Add openapi:json:indent Meta by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3480](https://togithub.com/goadesign/goa/pull/3480) - Fix validation code for projected union types by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3487](https://togithub.com/goadesign/goa/pull/3487) - Return a validation error when query string is malformed by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3488](https://togithub.com/goadesign/goa/pull/3488) - Properly handle decoding of maps with nil entries by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3490](https://togithub.com/goadesign/goa/pull/3490) - Correctly handle union to union transforms by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3491](https://togithub.com/goadesign/goa/pull/3491) **Full Changelog**: goadesign/goa@v3.15.0...v3.15.1 ### [`v3.15.0`](https://togithub.com/goadesign/goa/releases/tag/v3.15.0) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.14.6...v3.15.0) #### What's Changed - Standardize OpenAPI integer format by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3451](https://togithub.com/goadesign/goa/pull/3451) - Fix openapi:generate Meta to affect required validations by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3452](https://togithub.com/goadesign/goa/pull/3452) - Merge duplicate mustGenerate() functions by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3453](https://togithub.com/goadesign/goa/pull/3453) - Generate valid OpenAPI specifications by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3454](https://togithub.com/goadesign/goa/pull/3454) - Embed template files at compile time by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3455](https://togithub.com/goadesign/goa/pull/3455) - Skip flaky tests by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3458](https://togithub.com/goadesign/goa/pull/3458) - No need to checkout to report test coverage by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3459](https://togithub.com/goadesign/goa/pull/3459) - Use v3 branch for pushes and feature branch for PRs for code coverage by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3460](https://togithub.com/goadesign/goa/pull/3460) - Move templates out of Go code into their own files by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3456](https://togithub.com/goadesign/goa/pull/3456) - Fix env var expansion in DeepSource GitHub action by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3463](https://togithub.com/goadesign/goa/pull/3463) - Fix godoc for codegen.UserTypeLocation() by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3464](https://togithub.com/goadesign/goa/pull/3464) - Use crypto/rand for sampling by [@​nitinmohan87](https://togithub.com/nitinmohan87) in [https://github.com/goadesign/goa/pull/3466](https://togithub.com/goadesign/goa/pull/3466) - Fix/trace sampler by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3467](https://togithub.com/goadesign/goa/pull/3467) - Make receiver consistent across all methods of ServiceError by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3468](https://togithub.com/goadesign/goa/pull/3468) - Treat nested paths for struct:pkg:path Meta by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3469](https://togithub.com/goadesign/goa/pull/3469) - Validate Array and Map for struct:pkg:path Meta by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3474](https://togithub.com/goadesign/goa/pull/3474) - Protect against invalid route captures by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3476](https://togithub.com/goadesign/goa/pull/3476) **Full Changelog**: goadesign/goa@v3.14.6...v3.15.0 ### [`v3.14.6`](https://togithub.com/goadesign/goa/releases/tag/v3.14.6) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.14.5...v3.14.6) #### What's Changed - Properly generate format for primitive types in OpenAPI specs by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3447](https://togithub.com/goadesign/goa/pull/3447) - Properly handle MapParams by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3450](https://togithub.com/goadesign/goa/pull/3450) **Full Changelog**: goadesign/goa@v3.14.5...v3.14.6 ### [`v3.14.5`](https://togithub.com/goadesign/goa/releases/tag/v3.14.5) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.14.4...v3.14.5) #### What's Changed - Fix godoc for openapi:generate Meta by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3443](https://togithub.com/goadesign/goa/pull/3443) - Add Speakeasy sponsorship banner by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3444](https://togithub.com/goadesign/goa/pull/3444) - Add APIName constant to generated code by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3445](https://togithub.com/goadesign/goa/pull/3445) - Corrected MapParams Behavior to Avoid Unintended Filtering by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3446](https://togithub.com/goadesign/goa/pull/3446) **Full Changelog**: goadesign/goa@v3.14.4...v3.14.5 ### [`v3.14.4`](https://togithub.com/goadesign/goa/releases/tag/v3.14.4) #### What's Changed - Add openapi:generate Meta support to dsl.Attribute by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/goadesign/goa/pull/3437](https://togithub.com/goadesign/goa/pull/3437) - Add API version constant to generated code by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3439](https://togithub.com/goadesign/goa/pull/3439) - Deprecate obsolete instrumentation by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3440](https://togithub.com/goadesign/goa/pull/3440) - Handle inline object array and map elements by [@​raphael](https://togithub.com/raphael) in [https://github.com/goadesign/goa/pull/3442](https://togithub.com/goadesign/goa/pull/3442) **Full Changelog**: goadesign/goa@v3.14.1...v3.14.4 ### [`v3.14.2`](https://togithub.com/goadesign/goa/compare/v3.14.1...v3.14.2) [Compare Source](https://togithub.com/goadesign/goa/compare/v3.14.1...v3.14.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PingCAP-QE/ee-apps). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e coverage