New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface instead of using testing.T #733

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
2 participants
@arangamani
Copy link
Contributor

arangamani commented Aug 15, 2016

No description provided.

@raphael

This comment has been minimized.

Copy link
Member

raphael commented Aug 15, 2016

Thank you!

@raphael raphael merged commit 41b6ae7 into goadesign:master Aug 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ikawaha added a commit to ikawaha/goa that referenced this pull request Dec 13, 2016

@ikawaha ikawaha referenced this pull request Dec 13, 2016

Merged

Backporting unmerged features/fixes to v1 branch. #965

5 of 5 tasks complete

raphael added a commit that referenced this pull request Dec 14, 2016

Backporting unmerged features/fixes to v1 branch. (#965)
* Added the ability to dynamically add/remove keys from the jwt security middleware after creation. (#818)

* Refactor JWT key resolver (#832)

To introduce new "simple" resolver.

* Add an interface instead of using testing.T (#733)

* removed unneeded check which would make an unsafe concurrent modification (#736)

- logit() doesn't need to modify a.keyvals because it was already fixed up in New()

* Modify metrics so that names are normalized to legal chars (#771)

* Add normalizeKeys() function for normalizing metric key names

* Properly synchronize updates to metrics object

* Fix setting a default value to datetime

* Add tests for a default value of datetime

* address issue #738 by creating a title for the test file

* Fix a finalize test

* Revert "Refactor JWT key resolver (#832)"

This reverts commit f6ecb66.

* Revert "Added the ability to dynamically add/remove keys from the jwt security middleware after creation. (#818)"

This reverts commit 4c7fc9d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment