Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support destructing of process.env #324

Closed
wants to merge 2 commits into from

Conversation

row248-hola
Copy link

Link to issue

#323

Description of changes being made

  • What was the solution to the problem?

Transforming

const {VARIABLE1, VARIABLE2} = process.env;

to

const {VARIABLE1 = "VALUE1", VARIABLE2 = "VALUE2" } = process.env;

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Base: 98.97% // Head: 97.29% // Decreases project coverage by -1.68% ⚠️

Coverage data is based on head (1933b2f) compared to base (3a940cb).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   98.97%   97.29%   -1.69%     
==========================================
  Files           1        1              
  Lines          98      111      +13     
==========================================
+ Hits           97      108      +11     
- Misses          1        3       +2     
Impacted Files Coverage Δ
index.js 97.29% <88.23%> (-1.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 31, 2022
@stale stale bot closed this Aug 10, 2022
@goatandsheep goatandsheep reopened this Oct 12, 2022
@stale stale bot removed the wontfix This will not be worked on label Oct 12, 2022
@goatandsheep goatandsheep self-requested a review October 27, 2022 16:36
@goatandsheep
Copy link
Owner

do you want help on this MR?

@row248-hola
Copy link
Author

@goatandsheep It's have been a long time. If it's only about resolving conflicts I can do it in a few days

@stale
Copy link

stale bot commented Jan 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 2, 2023
@stale stale bot closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants