Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: fix missing schemas attribute for User and Group #7477

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 7, 2023

Details

closes #7460

previously we started off with an empty dict which didn't contain the correct default values


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner November 7, 2023 09:43
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 16594b9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65554c060742220008f97944

@BeryJu BeryJu force-pushed the providers/scim/fix-missing-schemas branch 4 times, most recently from 26faae0 to 9b7bf9d Compare November 7, 2023 20:48
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99cecdb) 92.59% compared to head (16594b9) 92.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7477      +/-   ##
==========================================
+ Coverage   92.59%   92.60%   +0.01%     
==========================================
  Files         587      587              
  Lines       29032    29034       +2     
==========================================
+ Hits        26882    26888       +6     
+ Misses       2150     2146       -4     
Flag Coverage Δ
e2e 50.82% <50.00%> (+0.01%) ⬆️
integration 25.99% <50.00%> (+<0.01%) ⬆️
unit 89.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the providers/scim/fix-missing-schemas branch from 9b7bf9d to 41abc01 Compare November 15, 2023 22:33
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu
Copy link
Member Author

BeryJu commented Nov 15, 2023

/cherry-pick version-2023.10

@BeryJu BeryJu merged commit 51d3511 into main Nov 16, 2023
58 of 63 checks passed
@BeryJu BeryJu deleted the providers/scim/fix-missing-schemas branch November 16, 2023 10:36
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 16, 2023
* providers/scim: fix missing schemas attribute for User and Group

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* make things actually work

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 16, 2023
…rry-pick #7477) (#7596)

providers/scim: fix missing schemas attribute for User and Group (#7477)

* providers/scim: fix missing schemas attribute for User and Group



* make things actually work



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Nov 17, 2023
* main: (42 commits)
  stages/authenticator_totp: fix API validation error due to choices (#7608)
  website: fix pricing page inconsistency (#7607)
  web: bump API Client version (#7602)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7603)
  core: bump goauthentik.io/api/v3 from 3.2023103.2 to 3.2023103.3 (#7606)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7604)
  Revert "web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)"
  root: fix API schema for kotlin (#7601)
  web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7583)
  events: fix missing model_* events when not directly authenticated (#7588)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7594)
  providers/scim: fix missing schemas attribute for User and Group (#7477)
  core: bump pydantic from 2.5.0 to 2.5.1 (#7592)
  web/admin: contextually add user to group when creating user from group page (#7586)
  website/blog: title and slug change (#7585)
  events: sanitize functions (#7587)
  stages/email: use uuid for email confirmation token instead of username (#7581)
  website/blog: Blog about zero trust and wireguard (#7567)
  ci: translation-advice: avoid commenting after make i18n-extract
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SCIM JSON for User and Group is missing the schema attribute
2 participants