Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: sanitize functions #7587

Merged
merged 1 commit into from Nov 15, 2023
Merged

events: sanitize functions #7587

merged 1 commit into from Nov 15, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 15, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 15, 2023 20:36
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 3fb3404
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65552bb20e9caf0008f7d39b
😎 Deploy Preview https://deploy-preview-7587--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BeryJu
Copy link
Member Author

BeryJu commented Nov 15, 2023

/cherry-pick version-2023.10

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 3fb3404
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/65552bb2dd893100083b0fd6
😎 Deploy Preview https://deploy-preview-7587--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (no change from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 80 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9db9ad3) 89.62% compared to head (3fb3404) 92.59%.
Report is 41 commits behind head on main.

Files Patch % Lines
authentik/events/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7587      +/-   ##
==========================================
+ Coverage   89.62%   92.59%   +2.97%     
==========================================
  Files         587      587              
  Lines       28989    29032      +43     
==========================================
+ Hits        25982    26883     +901     
+ Misses       3007     2149     -858     
Flag Coverage Δ
e2e 50.89% <50.00%> (?)
integration 25.98% <50.00%> (?)
unit 89.65% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 3d66923 into main Nov 15, 2023
63 of 64 checks passed
@BeryJu BeryJu deleted the events/handle-function branch November 15, 2023 20:56
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Nov 15, 2023
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Nov 15, 2023
events: sanitize functions (#7587)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Nov 17, 2023
* main: (42 commits)
  stages/authenticator_totp: fix API validation error due to choices (#7608)
  website: fix pricing page inconsistency (#7607)
  web: bump API Client version (#7602)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7603)
  core: bump goauthentik.io/api/v3 from 3.2023103.2 to 3.2023103.3 (#7606)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7604)
  Revert "web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)"
  root: fix API schema for kotlin (#7601)
  web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7583)
  events: fix missing model_* events when not directly authenticated (#7588)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7594)
  providers/scim: fix missing schemas attribute for User and Group (#7477)
  core: bump pydantic from 2.5.0 to 2.5.1 (#7592)
  web/admin: contextually add user to group when creating user from group page (#7586)
  website/blog: title and slug change (#7585)
  events: sanitize functions (#7587)
  stages/email: use uuid for email confirmation token instead of username (#7581)
  website/blog: Blog about zero trust and wireguard (#7567)
  ci: translation-advice: avoid commenting after make i18n-extract
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant