events: fix missing model_* events when not directly authenticated #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7588 +/- ##
==========================================
+ Coverage 91.16% 92.61% +1.45%
==========================================
Files 587 587
Lines 29030 29042 +12
==========================================
+ Hits 26464 26898 +434
+ Misses 2566 2144 -422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick version-2023.10 |
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
✅ Deploy Preview for authentik ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
…7588) * events: fix missing model_* events when not directly authenticated Signed-off-by: Jens Langhammer <jens@goauthentik.io> * defer accessing database Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu
added a commit
that referenced
this pull request
Nov 16, 2023
…herry-pick #7588) (#7597) events: fix missing model_* events when not directly authenticated (#7588) * events: fix missing model_* events when not directly authenticated * defer accessing database --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik
added a commit
that referenced
this pull request
Nov 17, 2023
* main: (42 commits) stages/authenticator_totp: fix API validation error due to choices (#7608) website: fix pricing page inconsistency (#7607) web: bump API Client version (#7602) translate: Updates for file web/xliff/en.xlf in zh_CN (#7603) core: bump goauthentik.io/api/v3 from 3.2023103.2 to 3.2023103.3 (#7606) translate: Updates for file web/xliff/en.xlf in zh-Hans (#7604) Revert "web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)" root: fix API schema for kotlin (#7601) web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486) translate: Updates for file web/xliff/en.xlf in zh-Hans (#7583) events: fix missing model_* events when not directly authenticated (#7588) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7594) providers/scim: fix missing schemas attribute for User and Group (#7477) core: bump pydantic from 2.5.0 to 2.5.1 (#7592) web/admin: contextually add user to group when creating user from group page (#7586) website/blog: title and slug change (#7585) events: sanitize functions (#7587) stages/email: use uuid for email confirmation token instead of username (#7581) website/blog: Blog about zero trust and wireguard (#7567) ci: translation-advice: avoid commenting after make i18n-extract ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
previously certain events were not created in an un-authenticated session, which would typically impact flow executions as especially for signups the session is not authenticated
closes #4878
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)make i18n-extract)If applicable
make website)