Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stages/authenticator_totp: fix API validation error due to choices #7608

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 17, 2023

Details

Due to the kotlin API change


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 17, 2023 12:35
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit ca216ae
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65575e017dad0100089210d1

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a48ccbc) 49.49% compared to head (ca216ae) 92.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7608       +/-   ##
===========================================
+ Coverage   49.49%   92.61%   +43.11%     
===========================================
  Files         587      587               
  Lines       29044    29046        +2     
===========================================
+ Hits        14376    26901    +12525     
+ Misses      14668     2145    -12523     
Flag Coverage Δ
e2e 50.83% <100.00%> (+1.33%) ⬆️
integration 25.98% <0.00%> (?)
unit 89.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit ce86b20 into main Nov 17, 2023
64 checks passed
@BeryJu BeryJu deleted the stages/authenticator_totp-fix-api branch November 17, 2023 12:52
kensternberg-authentik added a commit that referenced this pull request Nov 17, 2023
* main: (42 commits)
  stages/authenticator_totp: fix API validation error due to choices (#7608)
  website: fix pricing page inconsistency (#7607)
  web: bump API Client version (#7602)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7603)
  core: bump goauthentik.io/api/v3 from 3.2023103.2 to 3.2023103.3 (#7606)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7604)
  Revert "web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)"
  root: fix API schema for kotlin (#7601)
  web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7583)
  events: fix missing model_* events when not directly authenticated (#7588)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7594)
  providers/scim: fix missing schemas attribute for User and Group (#7477)
  core: bump pydantic from 2.5.0 to 2.5.1 (#7592)
  web/admin: contextually add user to group when creating user from group page (#7586)
  website/blog: title and slug change (#7585)
  events: sanitize functions (#7587)
  stages/email: use uuid for email confirmation token instead of username (#7581)
  website/blog: Blog about zero trust and wireguard (#7567)
  ci: translation-advice: avoid commenting after make i18n-extract
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant