Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: fix API schema for kotlin #7601

Merged
merged 1 commit into from
Nov 16, 2023
Merged

root: fix API schema for kotlin #7601

merged 1 commit into from
Nov 16, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 16, 2023

Details

  • Rename System serializer to SystemInfo (System clashes with the kotlin import)
  • Make digits for TOTP stage be a text enum (kotlin doesn't call .toString() on it when it needs to)

See goauthentik/client-kotlin#4


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested review from a team as code owners November 16, 2023 22:54
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit aff1fc3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/65569ddaf7ecbb0008812cad
😎 Deploy Preview https://deploy-preview-7601--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (60af4a2) 92.61% compared to head (aff1fc3) 49.57%.

Files Patch % Lines
authentik/admin/api/system.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7601       +/-   ##
===========================================
- Coverage   92.61%   49.57%   -43.04%     
===========================================
  Files         587      587               
  Lines       29044    29044               
===========================================
- Hits        26899    14400    -12499     
- Misses       2145    14644    +12499     
Flag Coverage Δ
e2e 49.57% <71.42%> (-1.26%) ⬇️
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit b5e059d into main Nov 16, 2023
53 of 61 checks passed
@BeryJu BeryJu deleted the root/fix-api-for-kotlin branch November 16, 2023 23:07
kensternberg-authentik added a commit that referenced this pull request Nov 17, 2023
* main: (42 commits)
  stages/authenticator_totp: fix API validation error due to choices (#7608)
  website: fix pricing page inconsistency (#7607)
  web: bump API Client version (#7602)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#7603)
  core: bump goauthentik.io/api/v3 from 3.2023103.2 to 3.2023103.3 (#7606)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7604)
  Revert "web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)"
  root: fix API schema for kotlin (#7601)
  web: bump @lit-labs/context from 0.4.1 to 0.5.1 in /web (#7486)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#7583)
  events: fix missing model_* events when not directly authenticated (#7588)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_TW (#7594)
  providers/scim: fix missing schemas attribute for User and Group (#7477)
  core: bump pydantic from 2.5.0 to 2.5.1 (#7592)
  web/admin: contextually add user to group when creating user from group page (#7586)
  website/blog: title and slug change (#7585)
  events: sanitize functions (#7587)
  stages/email: use uuid for email confirmation token instead of username (#7581)
  website/blog: Blog about zero trust and wireguard (#7567)
  ci: translation-advice: avoid commenting after make i18n-extract
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant