Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart server if gobpie.json is changed #23

Closed
karoliineh opened this issue Mar 10, 2022 · 4 comments · Fixed by #25
Closed

Restart server if gobpie.json is changed #23

karoliineh opened this issue Mar 10, 2022 · 4 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request

Comments

@karoliineh
Copy link
Member

As the Goblint server can only reparse files and not analyse a new set of files when the server is already running, the server must be shut down and started again if a new set of files is passed. Right now one must always close and reopen VSCode to start an analysis on different sets of files in the project, which is quite inconvenient.

@karoliineh karoliineh added the enhancement New feature or request label Mar 10, 2022
@karoliineh karoliineh self-assigned this Mar 10, 2022
@sim642
Copy link
Member

sim642 commented Mar 10, 2022

With #24 the files field would move from gobpie.json to goblint.json, but the overall point still remains. It's just that if goblint.json is changed, the server should also be restarted.

@michael-schwarz
Copy link
Member

michael-schwarz commented Oct 11, 2022 via email

@sim642
Copy link
Member

sim642 commented Oct 11, 2022

Such command was already added in goblint/analyzer#817 since our loading of configs is really a cumulative merging of configs. So in order to be able to get predictable behavior on config file changes, it was necessary to also reset and re-merge instead.

As usual with the server, the advantage still is that it avoids having to marshal and unmarshal all the incremental data just to add a new file to the analyzed project, etc.

@michael-schwarz
Copy link
Member

I sent the email with this comment on Thu, Mar 10, 10:02 PM, very strange that it appeared here yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants