This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fixed regex bug on plugin installation match (related to #84) #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake when I wrote a regex for
NewPlugin(). It prevented adding a version tag when running thebuffalo plugin installcommand. This PR fixed that issue and added test cases.Issue
buffalo plugin install github.com/gobuffalo/buffalo-awesome/v2worksbuffalo plugin install github.com/gobuffalo/buffalo-awesome/v2@latestworksbuffalo plugin install github.com/gobuffalo/buffalo-awesomeworksbuffalo plugin install github.com/gobuffalo/buffalo-awesome@latestdoesn't workbuffalo-awesome@latestis the command nameFix
@too.Additionally, fixed one deprecation warning on
Plugins.Decode().related previous pr: #84