Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fixed plugin management related bugs #84

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Dec 15, 2021

Fixed several bugs related to plugin management:

  • fixed related bug on buffalo fix (cannot remove old one, just add new one, but filed to go get)
  • automatically add @latest if the module path has no tag (to make it easy to work with go install style)
    • now it supports buffalo plugins install github.com/gobuffalo/buffalo-pop/v3
    • along with buffalo plugins install github.com/gobuffalo/buffalo-pop/v3@latest
  • reliably remove the old version of buffalo-pop and install the new one.
  • changed command-line argument for buffalo plugins remove from package path to plugin name.
    • previously buffalo plugins remove github.com/gobuffalo/buffalo-pop/v3@latest (which is not working properly)
    • now buffalo plugins remove buffalo-pop, intuitive and simple.
  • deduplicated add/install codes (added plugdeps.NewPlugin())
  • changed key() method. the binary name should be unique, so just use it.
  • fixed cache registered twice

Detailed issue description and fixed behavior are in #83.

Fixes #83

@sio4 sio4 added bug Something isn't working enhancement New feature or request labels Dec 15, 2021
@sio4 sio4 requested review from paganotoni and a team December 15, 2021 17:14
@sio4 sio4 self-assigned this Dec 15, 2021
@sio4 sio4 linked an issue Dec 15, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

another fixer bug on fixing plugins. (not only fix but also some others)
3 participants