Adding before and after tags #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 22, 2018 16:46
Refactor tag.String to call parseTagEmbed for handling the types for tag.Body, tag.BeforeTag, tag.AfterTag interfaces TODO: Dry up tag.String() further. Multiple calls to tag.AfterTag conditional based on body tags.Options and and voidTag conditional logic that surrounds closing the Tag.
markbates
suggested changes
Jan 23, 2018
tag.go
Outdated
| func (t Tag) String() string { | ||
| bb := &bytes.Buffer{} | ||
|
|
||
| if len(t.BeforeTag) > 0 { |
There was a problem hiding this comment.
You don't need this if statement. The range will only run if there anything in the slice.
tag.go
Outdated
| bb.WriteString("</") | ||
| bb.WriteString(t.Name) | ||
| bb.WriteString(">") | ||
|
|
||
| if len(t.AfterTag) > 0 { |
There was a problem hiding this comment.
You don't need this if statement. The range will only run if there anything in the slice.
tag.go
Outdated
| bb.WriteString("></") | ||
| bb.WriteString(t.Name) | ||
| bb.WriteString(">") | ||
|
|
||
| if len(t.AfterTag) > 0 { |
There was a problem hiding this comment.
You don't need this if statement. The range will only run if there anything in the slice.
tag.go
Outdated
| return bb.String() | ||
| } | ||
| bb.WriteString(" />") | ||
|
|
||
| if len(t.AfterTag) > 0 { |
There was a problem hiding this comment.
You don't need this if statement. The range will only run if there anything in the slice.
markbates
suggested changes
Jan 23, 2018
tag.go
Outdated
| @@ -43,8 +51,34 @@ type htmler interface { | |||
| HTML() template.HTML | |||
| } | |||
|
|
|||
| func parseTagEmbed(b interface{}, bb *bytes.Buffer) { | |||
There was a problem hiding this comment.
Have this return a string instead of taking in a bytes.Buffer, it seems a little too "tied to implementation"
wolves
changed the title
markbates
approved these changes
Jan 24, 2018
|
@paganotoni looks good to me. its yours to merge and release. :) |
paganotoni
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an implementation of before/after_tag for the ability to specify a string or other tag within the
tags.Options{}which will primarily help when using tags with bootstrap, as shown in the example.Example:
Output:
Looking for criticisms/critiques/notes...