Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate default metadata value for MySQL #19

Merged
merged 3 commits into from
Sep 2, 2014
Merged

Conversation

appleton
Copy link
Contributor

Closes #16

@appleton
Copy link
Contributor Author

@MarkoHiel it would be great if you could install and test this branch before I merge it. Does it fix your issue?

@sunaot
Copy link

sunaot commented Apr 28, 2014

Hi, my project had the same issue mentioned at #16, and I tested the project with this patch and found the patch works fine to my repo. Thanks.

@pacso
Copy link
Contributor

pacso commented Sep 1, 2014

Hello,

Just wondering if there's any reason this pull request hasn't been merged yet? I just started using statesman with the version released 2 weeks ago and this issue is still present. Wasn't a big deal to resolve ... I'm just glad I checked the existing issues before I raised another one for this.

Conflicts:
	lib/generators/statesman/active_record_transition_generator.rb
	lib/generators/statesman/migration_generator.rb
@appleton
Copy link
Contributor Author

appleton commented Sep 2, 2014

You're right, there's no reason it's not been merged. I'll do it now!

appleton added a commit that referenced this pull request Sep 2, 2014
Don't generate default metadata value for MySQL
@appleton appleton merged commit bfc0c55 into master Sep 2, 2014
@appleton appleton deleted the mysql-default branch September 2, 2014 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Value for metadata doesn't work
3 participants