Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if one of the rules is not declared, no error will be thrown #666

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

whitebear009
Copy link
Contributor

What type of PR is this?

optimzation

What this PR does / why we need it:

For example, if the user does not need the indicators of the external rule, there is no necessary to declare it. That is correct so no need to throw error in this case.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-12-28 11:08
Git Version: 6be8eaa

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-666-6be8eaa docker pull gocrane/crane-agent:pr-666-6be8eaa
dashboard:pr-666-6be8eaa docker pull gocrane/dashboard:pr-666-6be8eaa
metric-adapter:pr-666-6be8eaa docker pull gocrane/metric-adapter:pr-666-6be8eaa
craned:pr-666-6be8eaa docker pull gocrane/craned:pr-666-6be8eaa

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-666-6be8eaa \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-666-6be8eaa \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-666-6be8eaa \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-666-6be8eaa crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-666-6be8eaa docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-666-6be8eaa
dashboard:pr-666-6be8eaa docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-666-6be8eaa
metric-adapter:pr-666-6be8eaa docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-666-6be8eaa
craned:pr-666-6be8eaa docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-666-6be8eaa

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-666-6be8eaa \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-666-6be8eaa \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-666-6be8eaa \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-666-6be8eaa crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-666-6be8eaa docker pull ghcr.io/gocrane/crane/crane-agent:pr-666-6be8eaa
dashboard:pr-666-6be8eaa docker pull ghcr.io/gocrane/crane/dashboard:pr-666-6be8eaa
metric-adapter:pr-666-6be8eaa docker pull ghcr.io/gocrane/crane/metric-adapter:pr-666-6be8eaa
craned:pr-666-6be8eaa docker pull ghcr.io/gocrane/crane/craned:pr-666-6be8eaa

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-666-6be8eaa \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-666-6be8eaa \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-666-6be8eaa \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-666-6be8eaa crane/crane

@qmhu qmhu requested a review from saikey0379 December 28, 2022 10:48
@qmhu qmhu merged commit 4697d27 into gocrane:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants