Drop PHP tests in 7.3 and add them in 8.1 #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download coblocks.zip: https://44216-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2272.zip |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
olafleur-godaddy
requested review from
AnthonyLedesma,
EvanHerman and
jrtashjian
as code owners
olafleur-godaddy
commented
Feb 9, 2022
olafleur-godaddy
commented
Feb 9, 2022
|
@olafleur-godaddy OK yeah it doesn't matter if support has been dropped, we still claim our stuff will run on PHP 5.6 so we should test it. Perhaps sometime later this year we can drop it. |
olafleur-godaddy
removed request for
jrtashjian,
jonathanbardo,
EvanHerman,
AnthonyLedesma and
fjarrett-godaddy
jonathanbardo
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description