fix: remove addons method for Storbook 5.x #20
Conversation
There was a problem hiding this comment.
I'd like @indexzero to weigh in. I don't remember the exact issues around this. I know it was to try to dynamically add in ./examples/.setup/addons.js. Removing that is definitely a breaking change. And if we want to remove it, there's definitely other pieces that should get removed here as well.
|
Storybook no longer expects an |
There was a problem hiding this comment.
👍reading the latest Storybook docs on writing presets addons appears to be an Array, not a function that returns an Array.
Not sure where that changed, but if this is released as a major semver bump it will cover any unexpected breaking changes to consumers.
|
5.2.0 -> 5.3.0 was a breaking change in storybook: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-52x-to-53x |
|
@indexzero it changed here: https://medium.com/storybookjs/declarative-storybook-configuration-49912f77b78 Which to them is not considered major. |
|
I'm okay with this PR, but we should probably publish as an alpha/beta until we get all the |
|
FYI they did get back to me on this error: storybookjs/storybook#9311 |
When running Storybook 5.3, I ran into an issue with this method being passed in where Storybook actually expects an array of presets. Removing this method enables Storybook to build and render as expected.
See the Storybook docs where
addonswas changed: https://storybook.js.org/docs/presets/introduction/#basic-usageBased on what I'm seeing in the docs I'd assume this is a breaking change.