Bump github/codeql-action from 1.1.5 to 2.1.6 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1.1.5 to 2.1.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8834766...28eead2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Dependabot tried to add |
|
The following labels could not be found: |
|
Superseded by #4. |
dependabot
bot
deleted the
dependabot/github_actions/github/codeql-action-2.1.6
branch
godofredoc
pushed a commit
that referenced
this pull request
Jan 13, 2023
… get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument
godofredoc
added a commit
that referenced
this pull request
Jan 25, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (flutter#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (flutter#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (flutter#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (flutter#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (flutter#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (flutter#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (flutter#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (flutter#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
godofredoc
added a commit
that referenced
this pull request
Jan 25, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (flutter#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (flutter#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (flutter#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (flutter#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (flutter#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (flutter#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (flutter#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (flutter#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
godofredoc
added a commit
that referenced
this pull request
Feb 3, 2023
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * comment fixes * test update * docstring fixes * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * 4dd8a694f Roll Skia from cc3e0cd0a743 to c776239198f7 (1 revision) (flutter/engine#38560) (flutter#117783) * 3460f349b [fuchsia] Set presentation interval (flutter/engine#38549) (flutter#117785) * Roll Flutter Engine from 3460f349b01d to 1752b5b84680 (2 revisions) (flutter#117788) * 332c0a2f2 Roll Skia from c776239198f7 to 13435162b783 (1 revision) (flutter/engine#38561) * 1752b5b84 Roll Dart SDK from 7f154f949aaf to fa6cf7241184 (2 revisions) (flutter/engine#38563) * a63bd854a [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) (flutter#117790) * Roll Flutter Engine from a63bd854ac5a to 5713a216076f (2 revisions) (flutter#117795) * e012dc825 [Windows] Add engine builder to simplify tests (flutter/engine#38546) * 5713a2160 Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter/engine#38562) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * 9095f7a8b Roll Dart SDK from fa6cf7241184 to 224ac5ed9c66 (1 revision) (flutter/engine#38569) (flutter#117799) * 0118b461b Roll Fuchsia Mac SDK from FeFYsNPy64-PEXPer... to 2lzQU8FEjR5AkOr4d... (flutter/engine#38571) (flutter#117800) * e03d7c8bb Roll Skia from 13435162b783 to 9e8f31e3020c (3 revisions) (flutter/engine#38572) (flutter#117802) * af6078b5f Roll Skia from 9e8f31e3020c to 486deb23bc2a (2 revisions) (flutter/engine#38574) (flutter#117804) * 7e5cc7bb6 Roll Dart SDK from 224ac5ed9c66 to 9f0d8b9f20da (1 revision) (flutter/engine#38575) (flutter#117805) * d4a04a538 Roll Fuchsia Linux SDK from KCm_e3N4gosNuY4IW... to IApTRqW8UUSWAOcqA... (flutter/engine#38578) (flutter#117817) * b202b3db9 Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter/plugins#6892) (flutter#117824) * Roll Flutter Engine from d4a04a538050 to 9153966bcb06 (2 revisions) (flutter#117830) * 53806fa1e Roll Fuchsia Mac SDK from 2lzQU8FEjR5AkOr4d... to Bewt-eq7gNu6sU_Ob... (flutter/engine#38579) * 9153966bc [fuchsia] Bump the target API level to 11 (flutter/engine#38544) * b9bf51d16 Roll Dart SDK from 9f0d8b9f20da to 881c0b56a1f7 (1 revision) (flutter/engine#38580) (flutter#117832) * Roll Flutter Engine from b9bf51d16f25 to f6ad9b6d00e3 (2 revisions) (flutter#117834) * 4b38736e7 [Impeller Scene] Import materials, load embedded textures (flutter/engine#38577) * f6ad9b6d0 Roll Fuchsia Linux SDK from IApTRqW8UUSWAOcqA... to CXcPP_JZKQbSu2eIP... (flutter/engine#38581) * 932591ec0 Roll Fuchsia Linux SDK from CXcPP_JZKQbSu2eIP... to PkN8FdI4aC9z7W4mI... (flutter/engine#38584) (flutter#117840) * 3d8c5ef10 Roll Fuchsia Linux SDK from PkN8FdI4aC9z7W4mI... to OOL-jWRElkQ2P3vJz... (flutter/engine#38585) (flutter#117846) * Roll Flutter Engine from 3d8c5ef1060c to a7decc3e459b (2 revisions) (flutter#117856) * 3470fa848 Roll Skia from 486deb23bc2a to a31d9c3b4583 (2 revisions) (flutter/engine#38586) * a7decc3e4 Roll Skia from a31d9c3b4583 to 01aeec883a43 (4 revisions) (flutter/engine#38587) * 0a2029cf3 Roll Fuchsia Linux SDK from OOL-jWRElkQ2P3vJz... to AE3lAqTc632VsY14L... (flutter/engine#38588) (flutter#117858) * 5fe7d5b4e Roll Skia from 01aeec883a43 to 2ffa04c2f77c (2 revisions) (flutter/engine#38591) (flutter#117863) * e5d605b3a Roll Skia from 2ffa04c2f77c to 269dce7e16bb (1 revision) (flutter/engine#38592) (flutter#117865) * 71c5f1704 Roll Fuchsia Linux SDK from AE3lAqTc632VsY14L... to UAq0LO56_kbgA_BUQ... (flutter/engine#38593) (flutter#117868) * 472e34cbb Roll Skia from 269dce7e16bb to fde37f5986fd (1 revision) (flutter/engine#38594) (flutter#117869) * Roll Plugins from b202b3db98dc to e85f8ac1502d (3 revisions) (flutter#117875) * 035d85e62 Roll Flutter from d2127ad to 120058f (15 revisions) (flutter/plugins#6896) * 80532e0ba Roll Flutter from 120058f to 0196e60 (3 revisions) (flutter/plugins#6901) * e85f8ac15 Roll Flutter from 0196e60 to b938dc1 (7 revisions) (flutter/plugins#6908) * [flutter_tools] timeline_test.dart flaky (flutter#116667) * contains name instead of remove last * fix expect * remove and expect on elements * delete unused code * 7e51aef0a Roll Skia from fde37f5986fd to 809e328ed55c (1 revision) (flutter/engine#38596) (flutter#117874) * Updated to tokens v0.150. (flutter#117350) * Updated to tokens v0.150. * Updated with a reverted list_tile.dart. * Simplify null check. (flutter#117026) * Simplify null check. * Simplify null check. * Simplify null check. * Fix. * Roll Flutter Engine from 7e51aef0a1be to 1d2ba73d1059 (9 revisions) (flutter#117923) * 3e1b0dcb2 Roll Dart SDK from 881c0b56a1f7 to 617e70c95f5b (1 revision) (flutter/engine#38597) * 8b17efed8 Roll Fuchsia Linux SDK from UAq0LO56_kbgA_BUQ... to LA5kW39Gec7KvvM7x... (flutter/engine#38598) * 27960a700 [Impeller Scene] Import animation data (flutter/engine#38583) * b5acb2099 Roll Skia from 809e328ed55c to 697f9b541a0e (1 revision) (flutter/engine#38599) * dd0335b34 Roll Skia from 697f9b541a0e to 15d36b15bca1 (1 revision) (flutter/engine#38601) * adda2e80c [Impeller Scene] Animation binding and playback (flutter/engine#38595) * 71a296d53 Roll Fuchsia Linux SDK from LA5kW39Gec7KvvM7x... to rPo4_TYHCtkoOfRup... (flutter/engine#38607) * bde8d4524 Implement ITextProvider and ITextRangeProvider for UIA (flutter/engine#38538) * 1d2ba73d1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) * Reland "Remove single-view assumption from ScrollPhysics (flutter#117503)" (flutter#117916) This reverts commit c956121. * Minor documentation fix on BorderRadiusDirectional.zero (flutter#117661) * fix typos (flutter#117592) * c0b3f8fce Make `AccessibilityBridge` a `AXPlatformTreeManager` (flutter/engine#38610) (flutter#117931) * Add convenience constructors for SliverList (flutter#116605) * init * lint * add the other two slivers * fix lint * add test for sliverlist.separated * add3 more * fix lint and tests * remove trailing spaces * remove trailing spaces 2 * fix lint * fix lint again * 2213b80dd [Impeller Scene] Use std::chrono for animation durations (flutter/engine#38606) (flutter#117935) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * == override parameters are non-nullable (flutter#117839) * Fix the message strings for xcodeMissing and xcodeIncomplete (flutter#117922) * Add macOS to xcodeMissing and xcodeIncomplete * And unit test * 32c468507 Roll quiver to 3.2.1 (flutter/engine#38617) (flutter#117942) * Send text direction in selection rects (flutter#117436) * Correctly propagate verbosity to subtasks in flutter.gradle (flutter#117897) * Correctly propagate verbosity to subtasks in flutter.gradle * Add test * Revert accidental changes * Fix copyright year * Fix imports * Roll Plugins from e85f8ac1502d to f9dda6a27b79 (3 revisions) (flutter#117972) * 6df3ef23f [in_app_pur] Add screenshots to pubspec.yaml (flutter/plugins#6540) * 42f8093c2 [google_maps_flutter] Fixed minor syntax error in the README.md (flutter/plugins#6909) * f9dda6a27 [image_picker_ios] Fix FLTPHPickerSaveImageToPathOperation property attributes (flutter/plugins#6890) * [flutter_tools] Fix null check in parsing web plugin from pubspec.yaml (flutter#117939) * fix null check in parsing web plugin yaml * revert accidental diff * remove comment * roll packages (flutter#117940) * roll packages (flutter#118001) * [Android] Increase timeout duration for spell check integration test (flutter#117989) * Add timeout * Add library directive * Add comment, remove testing only changes * Roll Flutter Engine from 32c468507b32 to cdd3bf29e27a (8 revisions) (flutter#118014) * 22f872d5e Roll Dart SDK from 617e70c95f5b to f6dcb8b0b5d3 (7 revisions) (flutter/engine#38626) * c5e0f9ed0 Roll Dart SDK from f6dcb8b0b5d3 to 0b064bc49557 (1 revision) (flutter/engine#38630) * 398f5d3bd Roll Skia from 15d36b15bca1 to 9423a8a0fc2d (37 revisions) (flutter/engine#38631) * ebf01dcdb Update FlutterPlatformNodeDelegate (flutter/engine#38615) * d7dbe5bf3 Roll Skia from 9423a8a0fc2d to 60e4a4a27375 (5 revisions) (flutter/engine#38633) * 67440ccd5 fix roll (flutter/engine#38635) * 87bdde8fe Fix build using VS 17.4's C++ STL (flutter/engine#38614) * cdd3bf29e make DisplayListFlags constexpr throughout (flutter/engine#38649) * 60515762e [Impeller Scene] Compute joint transforms and apply them to skinned meshes (flutter/engine#38628) (flutter#118016) * 35b7dee32 [Impeller] Set adaptive tolerance when rendering FillPathGeometry (flutter/engine#38497) (flutter#118017) * b9b0193ea Roll Skia from 60e4a4a27375 to 158d51b34caa (19 revisions) (flutter/engine#38654) (flutter#118018) * a01548f5f [Impeller Scene] Fix material/vertex color overlapping (flutter/engine#38653) (flutter#118027) * Roll Plugins from f9dda6a27b79 to 320461910156 (2 revisions) (flutter#118040) * 365332fe1 Roll Flutter from b938dc1 to 231855f (19 revisions) (flutter/plugins#6913) * 320461910 Update image_picker_ios CODEOWNER (flutter/plugins#6891) * 072a9ca37 Add `TextProvider` and `TextEdit` patterns to `AXPlatformNodeWin` (flutter/engine#38646) (flutter#118039) * bb4015269 Roll Skia from 158d51b34caa to ecd3a2f865ba (1 revision) (flutter/engine#38659) (flutter#118042) * Avoid using `TextAffinity` in `TextBoundary` (flutter#117446) * Avoid affinity like the plague * ignore lint * clean up * fix test * review * Move wordboundary to text painter * docs * fix tests * 74861f369 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) (flutter#118048) * 5bd90d6e7 Consider more roles as text (flutter/engine#38645) (flutter#118049) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * Adding 'is' to list of kotlin reserved keywords (flutter#116299) Co-authored-by: Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (flutter#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (flutter#118072) Co-authored-by: a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (flutter#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Clarify comment. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Reduce padding in ExpandIcon to 12px s.t. header height is 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Update testcases to new header height (56px -> 48px). Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Test for header height equal to 48px. Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Change issue number to link in comment * Add periods to comments Signed-off-by: Morris Kurz <morriskurz@gmail.com> * Roll Plugins from 320461910156 to 276cfd4b212d (2 revisions) (flutter#118099) * 3a6f63bed Roll Flutter from 231855f to 43b9120 (11 revisions) (flutter/plugins#6918) * 276cfd4b2 [shared_preferences] Convert macOS to Pigeon (flutter/plugins#6914) * 33d7f8a1b Remove single view assumptions from `window.dart` (flutter/engine#38453) (flutter#118069) * InteractiveViewer parameter to return to pre-3.3 trackpad/Magic Mouse behaviour (flutter#114280) * trackpadPanShouldActAsZoom * Address feedback * Move constant, add blank lines * 0a0e3d205 Roll Flutter from 43b9120 to 5070620 (9 revisions) (flutter/plugins#6919) (flutter#118183) * Roll Flutter Engine from 33d7f8a1b307 to 03609b420beb (6 revisions) (flutter#118125) * c58254702 SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) * 3d9214ace Bump actions/checkout from 3.1.0 to 3.2.0 (flutter/engine#38390) * a4775c7a7 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) * 046012e8e [fuchsia] Enable CI for branches like `fuchsia_r51a`. (flutter/engine#38683) * cda410c28 Roll Skia from ecd3a2f865ba to 54dbda290908 (12 revisions) (flutter/engine#38668) * 03609b420 [web] Fix canvas2d leaks in text measurement (flutter/engine#38640) * remove the unused check in selectable_text (flutter#117716) * Roll Flutter Engine from 03609b420beb to b5513d7a442a (2 revisions) (flutter#118186) * fd5a96e10 Limit selection change to focused node on Windows (flutter/engine#38634) * b5513d7a4 Roll Dart SDK from 0b064bc49557 to cb29cb6d1d0f (12 revisions) (flutter/engine#38688) * Roll Flutter Engine from b5513d7a442a to 5bdb04f33f99 (2 revisions) (flutter#118187) * e20809014 Roll Skia from 54dbda290908 to b8c0a78a2378 (43 revisions) (flutter/engine#38690) * 5bdb04f33 Roll Fuchsia Mac SDK from Bewt-eq7gNu6sU_Ob... to ORxExaprF9fW5d4MP... (flutter/engine#38697) * 51baed6e0 [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) (flutter#118189) * Update to Xcode 14.2 (flutter#117507) * Update to Xcode 14.2 * Only bump for devicelab builders * Restore presubmit: false * Allow iOS and macOS plugins to share darwin directory (flutter#115337) * Roll Flutter Engine from 51baed6e01b8 to 5df0072a0e63 (3 revisions) (flutter#118192) * 181286315 Roll Dart SDK from cb29cb6d1d0f to 853eff8b0faa (2 revisions) (flutter/engine#38694) * 642f72f73 Bump actions/upload-artifact from 3.1.0 to 3.1.2 (flutter/engine#38713) * 5df0072a0 Bump actions/checkout from 3.2.0 to 3.3.0 (flutter/engine#38714) * Use program during attach if provided (flutter#118130) * eb5c6f0b4 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) (flutter#118197) * Update `ListTile` to support Material 3 (flutter#117965) * Update `ListTile` to support Material 3 * Update `Default ListTile debugFillProperties` * Add flutter#99933 HTML workaround. * 3a7d8862f Re-enable UIA text/range provider unit tests (flutter/engine#38718) (flutter#118201) * Fix path for require.js (flutter#118120) - Matches new location in the Dart SDK. https://dart-review.googlesource.com/c/sdk/+/275482 - Includes fall back logic so the existing and new locations will work depending on the file that is available. * ee0c4d26b Roll flutter/packages to 25454e (flutter/engine#38685) (flutter#118205) * Roll Flutter Engine from ee0c4d26b0fa to 264aa032cf75 (2 revisions) (flutter#118208) * 5a39a8846 Add CI builder for windows-arm64. (flutter/engine#38394) * 264aa032c Revert "Add CI builder for windows-arm64. (flutter#38394)" (flutter/engine#38729) * 9c0b187a1 Roll Dart SDK from 853eff8b0faa to 418bee5da2e2 (4 revisions) (flutter/engine#38727) (flutter#118210) * add closed/open focus traversal; use open on web (flutter#115961) * allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments * Roll Flutter Engine from 9c0b187a1139 to 716bb9172c0d (3 revisions) (flutter#118220) * b6720a5b7 Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) * 4f0cdcd0b Inline usage of SkIsPow2 (flutter/engine#38722) * 716bb9172 [Impeller Scene] Add DisplayList OP and Dart bindings (flutter/engine#38676) * Hide InkWell hover highlight when an hovered InkWell is disabled (flutter#118026) * Allow select cases to be numbers (flutter#116625) * [Impeller Scene] Add SceneC asset importing (flutter#118157) * Add a comment about repeat event + fix typos (flutter#118095) * Add MaterialStateProperty `overlayColor` & `mouseCursor` and fix hovering on thumbs behavior (flutter#116894) * Roll Flutter Engine from 716bb9172c0d to 687e3cb0fbe2 (2 revisions) (flutter#118242) * 24ee5c10f Roll Fuchsia Mac SDK from ORxExaprF9fW5d4MP... to zC90VpkAGMG1jJ-BK... (flutter/engine#38734) * 687e3cb0f Roll Dart SDK from 418bee5da2e2 to 8d7a6aabd3a3 (2 revisions) (flutter/engine#38738) * Roll Plugins from 0a0e3d205ca3 to 9fdc899b72ca (8 revisions) (flutter#118253) * d03de2fce [tool] Don't add Guava in the all-packages app (flutter/plugins#6747) * d485c7e83 [local_auth]: Bump espresso-core (flutter/plugins#6925) * a47e71988 [webview_flutter_platform_interface] Improves error message when `WebViewPlatform.instance` is null (flutter/plugins#6938) * 7132dac0e [google_maps]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/plugins#6937) * dc3287ccf [espresso]: Bump truth from 1.4.0 to 1.5.0 in /packages/espresso/android (flutter/plugins#6707) * 1de6477bd [camera]: Bump camerax_version from 1.3.0-alpha01 to 1.3.0-alpha02 in /packages/camera/camera_android_camerax/android (flutter/plugins#6828) * fb405819e [shared_preferences] Merge iOS and macOS implementations (flutter/plugins#6920) * 9fdc899b7 [various] Enable `avoid_dynamic_calls` (flutter/plugins#6834) * Manually mark Windows run_debug_test_windows as unflaky (flutter#118112) * Marks Mac_arm64_android run_debug_test_android to be unflaky (flutter#117469) * Marks Mac_arm64_ios run_debug_test_macos to be unflaky (flutter#117990) * remove unsound mode web test (flutter#118256) * Update `CupertinoPicker` example (flutter#118248) * Update `CupertinoPicker` example * format lines * Revert making variable public * revert variable change * roll packages (flutter#118117) * Add option for opting out of enter route snapshotting. (flutter#118086) * Add option for opting out of enter route snapshotting. * Fix typo. * Merge find layers logic. * Add justification comment on why web is skipped in test. * Update documentation as suggested. * Update documentation as suggested. * roll packages (flutter#118272) * Roll Flutter Engine from 687e3cb0fbe2 to c1d61cf11da8 (6 revisions) (flutter#118274) * ad9052a38 Roll Dart SDK from 8d7a6aabd3a3 to b90a008ddb29 (1 revision) (flutter/engine#38740) * c4c97023f Mark nodes as `kIsLineBreakingObject` by default, TODO further distinctions (flutter/engine#38721) * f40af3eb4 Roll Dart SDK from b90a008ddb29 to 5e344de60564 (1 revision) (flutter/engine#38744) * 41cfbdd7e Roll Fuchsia Mac SDK from zC90VpkAGMG1jJ-BK... to 6xysoRPCXJ3cJX12x... (flutter/engine#38746) * 95c7b1f8a Make operator == parameter non-nullable (flutter/engine#38663) * c1d61cf11 Move canvaskit artifacts to expected location in Web SDK Archive (flutter/engine#38168) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * ae9e181e3 Roll Dart SDK from 5e344de60564 to 7b4d49402252 (1 revision) (flutter/engine#38756) (flutter#118287) * Fix Finnish TimeOfDate format (flutter#118204) * init * add test * Roll Flutter Engine from ae9e181e30c2 to 53bd4bbf9646 (3 revisions) (flutter#118289) * b9a723482 [web] retain GL/Gr context on window resize (flutter/engine#38576) * fd4360671 Add SpringAnimation.js from React Native (flutter/engine#38750) * 53bd4bbf9 Roll Skia from b8c0a78a2378 to e1f3980272f3 (24 revisions) (flutter/engine#38758) * 9ade91c8b removed forbidden skia include (flutter/engine#38761) (flutter#118296) * 8d7beac82 Roll Dart SDK from 7b4d49402252 to 23cbd61a1327 (1 revision) (flutter/engine#38764) (flutter#118297) * 6256f05db Roll Fuchsia Mac SDK from 6xysoRPCXJ3cJX12x... to a9NpYJbjhDRX9P9u4... (flutter/engine#38767) (flutter#118300) * FIX: UnderlineInputBorder hashCode and equality by including borderRadius (flutter#118284) * Bump actions/upload-artifact from 3.1.1 to 3.1.2 (flutter#118116) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@83fd05a...0b7f8ab) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (flutter#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93ea575...ac59398) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * 6048f9110 Roll Dart SDK from 23cbd61a1327 to 22fa50e09ee8 (3 revisions) (flutter/engine#38776) (flutter#118320) * Roll Plugins from 9fdc899b72ca to 620a059d62b2 (4 revisions) (flutter#118317) * 6a24f2d7b == override parameters are non-nullable (flutter/plugins#6900) * b9206bcfe [espresso]: Bump espresso-accessibility and espresso-idling-resource from 3.1.0 to 3.5.1 in /packages/espresso/android (flutter/plugins#6933) * b1797c2bb [file_selector] Switch to Pigeon for macOS (flutter/plugins#6902) * 620a059d6 [google_sign_in] Renames generated folder to js_interop. (flutter/plugins#6915) * ee76ab71e Cleanup Skia includes in image_generator/descriptor (flutter/engine#38775) (flutter#118335) * Roll Flutter Engine from ee76ab71e0a6 to cccaae2f3d8b (3 revisions) (flutter#118349) * 5ec03d7d1 Roll Fuchsia Mac SDK from a9NpYJbjhDRX9P9u4... to ao8fSjW8HrZSsu3yq... (flutter/engine#38782) * 87ead948e delete include of private GrMtlTypes header (flutter/engine#38783) * cccaae2f3 [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) * 764a9e012 Roll Skia from e1f3980272f3 to dfb838747295 (48 revisions) (flutter/engine#38790) (flutter#118355) * Roll Flutter Engine from 764a9e01204d to 4a8d6866a1c0 (2 revisions) (flutter#118357) * 7abc5f13a [web] Update felt to use generated JS runtime for Dart2Wasm. (flutter/engine#38786) * 4a8d6866a Add CI builder for windows-arm64. (flutter#38394) (flutter/engine#38739) * Marks Mac_ios complex_layout_scroll_perf_bad_ios__timeline_summary to be unflaky (flutter#111570) * Marks Mac channels_integration_test to be unflaky (flutter#111571) * Marks Mac_ios platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary to be unflaky (flutter#116668) * Fix `SliverAppBar.large` and `SliverAppBar.medium` do not use `foregroundColor` (flutter#118322) * docs: update docs about color property in material card (flutter#117263) * update docs * * * typo * Revert "typo" This reverts commit 3e25d4be337b1a41d24b1a86136606d6551b30cf. * Update card.dart * Update card.dart * Update card.dart * Fix M3 `Drawer` default shape in RTL (flutter#118185) * [M3] Add error state support for side property of CheckBox (flutter#118386) * Add error state support for side property * lint fixes * lint fixes * Roll Plugins from 620a059d62b2 to 39197f17ca59 (6 revisions) (flutter#118391) * 8c461cfde [gh_actions]: Bump ossf/scorecard-action from 2.0.6 to 2.1.2 (flutter/plugins#6882) * a119afd47 [in_app_pur]: Bump espresso-core from 3.4.0 to 3.5.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/plugins#6924) * 12266846e Roll Flutter from 5070620 to 7ddf42e (5 revisions) (flutter/plugins#6923) * 44098fe34 [shared_preferences] Switch to `shared_preferences_foundation` (flutter/plugins#6940) * 0dd166959 [tool] Replace `flutter format` (flutter/plugins#6946) * 39197f17c [gh_actions]: Bump actions/checkout from 3.1.0 to 3.3.0 (flutter/plugins#6935) * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * IconButtonTheme should be overridden by the AppBar/AppBarTheme's iconTheme and actionsIconTheme (flutter#118216) * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * [web] Update build to use generated JS runtime for Dart2Wasm. (flutter#118359) * Roll Flutter Engine from 4a8d6866a1c0 to c01465a18f31 (9 revisions) (flutter#118409) * 2d2c5e7eb Roll Dart SDK from 22fa50e09ee8 to 21f5de0ad596 (2 revisions) (flutter/engine#38796) * 24eb954da fix canvas drawLine bugs (flutter/engine#38753) * 2b024cbb6 [Impeller Scene] Change how property resolution works to fix Animation blending; add mutation log to nodes; enable backface culling; add vertex color contribution back to meshes (flutter/engine#38766) * 0192ea15e Roll Dart SDK from 21f5de0ad596 to 7879aa93da71 (1 revision) (flutter/engine#38804) * 5cd50f568 Roll Fuchsia Mac SDK from ao8fSjW8HrZSsu3yq... to gZ6xbsp2MRsoXfKgY... (flutter/engine#38806) * 4bf70c011 Roll Dart SDK from 7879aa93da71 to d7235947ff9b (1 revision) (flutter/engine#38808) * bb2d5e93a Roll Dart SDK from d7235947ff9b to edd406c07399 (2 revisions) (flutter/engine#38814) * 2a9fa7975 Revert "fix canvas drawLine bugs (flutter#38753)" (flutter/engine#38815) * c01465a18 Add wasm_release build to linux_host_engine.json (flutter/engine#38755) * Add MSYS2 detection on Windows Terminal (flutter#117612) As the results of "uname -s" command is like the below on MSYS2 on Windows Terminal, MSYS_NT-10.0-22621 This patch fixes the Flutter command working on this kind of systems. Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> * Add documentation for drag/fling offset in WidgetController. (flutter#118288) * Documentation for drag/fling offset * Fix typo * Fix typo 2 * Fix the docs_test * Fix the grammar * 688015782 fixed glfw example for arm64 (flutter/engine#38426) (flutter#118413) * Use correct API docs link in create --sample help message (flutter#118371) * Use correct API doc link in create --sample help message * Verify Flutter and Dart website links in tool help messages use https * Adjust test failure reasoning message * Roll Flutter Engine from 688015782762 to 35cfe9158648 (2 revisions) (flutter#118415) * e9b7a2d38 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) * 35cfe9158 Roll Fuchsia Mac SDK from gZ6xbsp2MRsoXfKgY... to nIPtQ59jG1pxyatOq... (flutter/engine#38819) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * 8aa26baa9 Roll Dart SDK from edd406c07399 to 20cca507d98b (1 revision) (flutter/engine#38823) (flutter#118420) * add generated_plugins.cmake (flutter#116581) Added files to the .gitignore that are generated on each "flutter pub get", so it's useless to ever commit these to a git repository. * Enable xcode cache cleanup for a few days. (flutter#118419) This is to ensure the xcode caches get back to a normal state as they seem to have gotten into a bad state after updating the xcode version. Bug: flutter#118324 Bug: flutter#118327 Bug: flutter#118328 * 99509a7e4 Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) (flutter#118425) * Roll Flutter Engine from 99509a7e4275 to f3f05368033b (2 revisions) (flutter#118429) * 091c785a4 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) * f3f053680 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * a62d25326 Roll Skia from dfb838747295 to cc983d28f3bf (27 revisions) (flutter/engine#38830) (flutter#118435) * dfa0327f8 Roll Skia from cc983d28f3bf to fd54be29a3cc (3 revisions) (flutter/engine#38833) (flutter#118436) * 07603c6d4 Roll Dart SDK from 20cca507d98b to 3d629d00a8d7 (2 revisions) (flutter/engine#38834) (flutter#118439) * Fix copying/applying font fallback with package (flutter#118393) * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * Add test to check that package prefix of font fallback is not duplicated * Fix duplicate package prefix of font family fallback * dec608917 Roll Fuchsia Mac SDK from nIPtQ59jG1pxyatOq... to 21nYb648VWbpxc36t... (flutter/engine#38839) (flutter#118445) * 970889b87 Roll Skia from fd54be29a3cc to c72c7bf7e45b (3 revisions) (flutter/engine#38840) (flutter#118448) * a512cebdc Roll Dart SDK from 3d629d00a8d7 to 645fd748e79e (1 revision) (flutter/engine#38841) (flutter#118454) * Roll Plugins from 39197f17ca59 to 92a5367d58df (4 revisions) (flutter#118457) * b89e4fc2d Roll Flutter from 7ddf42e to 0d91c03 (58 revisions) (flutter/plugins#6948) * 86eda6992 [path_provider] Switch to Pigeon for macOS (flutter/plugins#6635) * be2e3de7a [shared_preferences_foundation] Add Swift runtime search paths for Objective-C apps (flutter/plugins#6952) * 92a5367d5 [tool] Fix false positives in update-exceprts (flutter/plugins#6950) * Added LinearBorder, an OutlinedBorder like BoxBorder (flutter#116940) * Marks Mac_ios spell_check_test to be unflaky (flutter#117743) * [Linux] Add a 'flutter run' console output test (flutter#118279) * Add Linux support for the UI integration test project * Add Linux run console test * Add Info.plist from build directory as input path to Thin Binary build phase (flutter#118209) * Add Info.plist from build directory as input path to Thin Binary build phase * fix directive ordering * migrate benchmark, integration, and example tests * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter#118482) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.37 to 2.1.38. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@959cbb7...515828d) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove whitespace * add newline * newline fixes * newline fix * test fix * Update documentation about accent color (flutter#116778) * e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter#117779) * Roll Plugins from e11cb245bb8e to 2d66f30e5825 (2 revisions) (flutter#117781) * 417b37009 Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter/plugins#6889) * 2d66f30e5 [webview_flutter_web] Adds auto registration of the `WebViewPlatform` implementation (flutter/plugins#6886) * Roll Flutter Engine from 5713a216076f to 780082203ea9 (2 revisions) (flutter#117797) * fd94b04b1 [Impeller Scene] Import skinned mesh vertex data (flutter/engine#38554) * 780082203 Roll Fuchsia Linux SDK from gnyHyot4AZp7HZgUI... to KCm_e3N4gosNuY4IW... (flutter/engine#38568) * Reland "Add support for double tap and drag for text selection flutter#109573" (flutter#117502) * Revert "Revert "Add support for double tap and drag for text selection (flutter#109573)" (flutter#117497)" This reverts commit 39fa011. * Allow TapAndDragGestureRecognizer to accept pointer events from any devices -- the TapGestureRecognizer it replaces was previously doing this Co-authored-by: Renzo Olivares <roliv@google.com> * roll packages (flutter#117940) * roll packages (flutter#118001) * [EMPTY] Commit to refresh the tree that is currently red (flutter#118062) * Remove doc reference to the deprecated ui.FlutterWindow API (flutter#118064) * Fix `flutter update-packages` regression by fixing parameters in "pub get" runner (flutter#116687) * Make pub get runner respect printProgress and retry parameters * Fix typo * Add regression test * Improve test * Fix implementation and test * Test to fix flutter_drone tests * Revert test * Attempt #2 to fix flutter_drone tests * Revert attempt * Hack: Force printProgress to debug Windows tests * Use ProcessUtils.run to avoid dangling stdout and stderr * Update documentation * Clean up retry argument * [Impeller Scene] Add SceneC asset importing (flutter#118157) * roll packages (flutter#118117) * roll packages (flutter#118272) * Align `flutter pub get/upgrade/add/remove/downgrade` (flutter#117896) * Align `flutter pub get/upgrade/add/remove/downgrade` * Add final . to command description * Remove trailing whitespace * Don't print message that command is being run * Update expectations * Use relative path * Remove duplicated line * Improve function dartdoc * Bump github/codeql-action from 2.1.35 to 2.1.37 (flutter#117104) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.35 to 2.1.37. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b2a92eb...959cbb7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move debug error message from failed pub to logger.printTrace (flutter#118379) * Move debug error message from failed pub to logger.printTrace * Update test * [tool] Generate a binary version of the asset manifest (flutter#117233) * initial * update asset_bundle_package_test * Update asset_bundle_test.dart * Update asset_bundle_package_fonts_test.dart * update pubspec checksum for smc dependency * flutter update-packages --force-upgrade * prefer += 1 over ++ Co-authored-by: Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by: Jonah Williams <jonahwilliams@google.com> * reduce pub output from flutter create (flutter#118285) * reduce pub output from flutter create * fix fake Pub implementations * fix tests * Update pub.dart * replace enum with simpler boolean * fix tests * Revert "fix tests" This reverts commit 8a3182d. * Revert "replace enum with simpler boolean" This reverts commit 445dbc4. * go back to using an enum * roll packages (flutter#118277) * Fix tap/drag callbacks firing when TapAndDragGestureRecognizer has not won the arena (flutter#118342) * Prevent drag and tap from accepting when a tap down exceeds the recognizers deadline but the recognizer has not won the arena * Add test * make analyzer happy Co-authored-by: Renzo Olivares <roliv@google.com> * Add `allowedButtonsFilter` to prevent Draggable from appearing with secondary click. (flutter#111852) * DragTarget part 1. [WIP] Change GestureRecognizer. Sorry. [WIP] Move from GestureRecognizer to MultiDragGestureRecognizer. Make it a `Set<int>?` Get bitwise operations working. Fix test. Rename to allowedInputPointers. Convert into a builder. Improve code with default funciton. Refactor everything again. Rename to buttonEventFilter. Use static function. Fix analyzer. Fix private reference. Use // in private method. * Fix Renzo request. * Add `allowedButtonsFilter` everywhere. * Refactor monoDrag for multi pointer support. * Fix tests? * Change default to always true. * Fix PR comments. * Completely refactor long press. * Add forgotten class. * Revert "Completely refactor long press." This reverts commit 5038e8603e250e8c928b0f1754fb794b7b75738b. * Add default value to LongPress * Refactor doubleTap. * Relax double tap. * Write comment in LongPress. * Use template. * 15d59792e Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (flutter/engine#38827) (flutter#118432) * [flutter_tools] re-enable web shader compilation (flutter#118461) * [flutter_tools] re-enable web shader compilation * update test cases * remove whitespace * fix rebase mess * fix time picker tests * whitespace fix * actual whitespace fix --------- Signed-off-by: Morris Kurz <morriskurz@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by: Darren Austin <darrenaustin@google.com> Co-authored-by: Ahmed Ashour <asashour@yahoo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com> Co-authored-by: Greg Price <gnprice@gmail.com> Co-authored-by: CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by: Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by: Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by: Renzo Olivares <roliv@google.com> Co-authored-by: Sam Rawlins <srawlins@google.com> Co-authored-by: Peixin Li <pageli328@gmail.com> Co-authored-by: Callum Moffat <smartercallum@gmail.com> Co-authored-by: Vyacheslav Egorov <vegorov@google.com> Co-authored-by: Christopher Fujino <christopherfujino@gmail.com> Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by: Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by: Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by: gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by: Gray Mackall <mackall@google.com> Co-authored-by: Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by: Alex Wallen <wallenstephen@outlook.com> Co-authored-by: a-wallen <stephenwallen@google.com> Co-authored-by: Morris Kurz <morriskurz@gmail.com> Co-authored-by: Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Helin Shiah <helinx@google.com> Co-authored-by: Taha Tesser <tessertaha@gmail.com> Co-authored-by: Nicholas Shahan <nshahan@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by: Brandon DeRosier <bdero@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: Youchen Du <youchen.du@gmail.com> Co-authored-by: Sigurd Meldgaard <sigurdm@google.com> Co-authored-by: Rydmike <m.rydstrom@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Suhwan Cha <suhw4n@gmail.com> Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by: joshualitt <joshualitt@google.com> Co-authored-by: Deokgyu Yang <secugyu@gmail.com> Co-authored-by: Peixin Li <peixinli@google.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by: godofredoc <godofredoc@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by: Hans Muller <hans.muller@gmail.com> Co-authored-by: Victoria Ashworth <vashworth@google.com>
godofredoc
pushed a commit
that referenced
this pull request
Mar 21, 2023
…r#120936)" (flutter#122909)" (flutter#123031) [flutter_tools] Remove sound null safety flag #2
godofredoc
pushed a commit
that referenced
this pull request
Jun 20, 2023
…extMenuBuilder (flutter#128114) Close flutter#128113 Fun fact: This is caught by monkey testing I have written (will soon be open sourced as well) that runs on my app! Without the fix, the test fails as expected: <details> ``` (base) â�� flutter git:(feat/text-field-npe) /Volumes/MyExternal/ExternalRefCode/flutter/bin/flutter test test/material/text_field_test.dart --name 'changes from default' 00:06 +0: context menu contextMenuBuilder changes from default to null â��â��â�¡ EXCEPTION CAUGHT BY WIDGETS LIBRARY â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� The following _TypeError was thrown building _OverlayEntryWidget-[LabeledGlobalKey<_OverlayEntryWidgetState>#e3717](state: _OverlayEntryWidgetState#7666a): Null check operator used on a null value When the exception was thrown, this was the stack: #0 EditableTextState._createSelectionOverlay.<anonymous closure> (package:flutter/src/widgets/editable_text.dart:3331:43) #1 SelectionOverlay.showToolbar.<anonymous closure> (package:flutter/src/widgets/text_selection.dart:1357:36) #2 ContextMenuController.show.<anonymous closure> (package:flutter/src/widgets/context_menu_controller.dart:65:54) #3 _OverlayEntryWidgetState.build (package:flutter/src/widgets/overlay.dart:351:36) #4 StatefulElement.build (package:flutter/src/widgets/framework.dart:5198:27) #5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5086:15) #6 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #7 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #8 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #9 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #10 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:6093:32) #11 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6595:17) #12 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #14 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #15 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #16 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #17 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #18 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #19 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #20 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #21 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #22 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #23 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #24 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #25 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #26 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #27 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #28 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #29 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #30 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #31 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #32 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #33 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #34 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #35 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #36 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #37 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #38 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #39 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #40 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #41 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #42 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #43 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #44 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #45 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #46 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #47 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #48 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #49 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #50 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #51 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #52 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #53 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #54 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #55 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #56 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #57 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #58 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #59 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #61 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #62 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #63 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) #64 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #65 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) #66 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #67 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #68 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) #69 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #70 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) #71 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #73 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #74 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #75 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #77 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #78 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #79 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #81 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #82 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #83 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) #84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) #85 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) #86 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) #87 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#88 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#89 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#90 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#91 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#92 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#93 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#94 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#95 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#96 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#97 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#98 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#99 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#100 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#101 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#102 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#103 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#104 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#106 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#107 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#108 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#109 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#110 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#111 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#112 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#113 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#114 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#115 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#116 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#117 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#118 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#119 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#120 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#121 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#122 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#123 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#124 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#125 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#126 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#127 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#128 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#129 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#130 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#131 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#132 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#133 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#134 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#135 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#136 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#137 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#138 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#139 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#140 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#141 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#142 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#143 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#144 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#145 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#146 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#147 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#148 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#149 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#150 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#151 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#152 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#153 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#154 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#155 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#156 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#157 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#158 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#159 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#160 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#161 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#162 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#163 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#164 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#165 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#166 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#167 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#168 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#169 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#170 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#171 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#172 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#173 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#174 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#175 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#176 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#177 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#178 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#179 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#180 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#181 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#182 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#183 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#184 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#185 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#186 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#187 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#188 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#189 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#190 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#191 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#192 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#193 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#194 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#195 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#196 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#197 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#198 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#199 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#200 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#201 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#202 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#203 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#204 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#205 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#206 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#207 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#208 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#209 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#210 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#211 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#212 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#213 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#214 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#215 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#216 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#217 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#218 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#219 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#220 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#221 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#222 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#223 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#224 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#225 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#226 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#227 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#228 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#229 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#230 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#231 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#232 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#233 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#234 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#235 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#236 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#237 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#238 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#239 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#240 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#241 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#242 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#243 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#244 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#245 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#246 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#247 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#248 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#249 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#250 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#251 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#252 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#253 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#254 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#255 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#256 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#257 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#258 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#259 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#260 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#261 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#262 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#263 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#264 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#265 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#266 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#267 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#268 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#269 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#270 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#271 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#272 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#273 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#274 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#275 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#276 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#277 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:6442:14) flutter#278 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#279 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#280 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#281 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#282 _InheritedNotifierElement.update (package:flutter/src/widgets/inherited_notifier.dart:107:11) flutter#283 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#284 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#285 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#286 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#287 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#288 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#289 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#290 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#291 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#292 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#293 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#294 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#295 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#296 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#297 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#298 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#299 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#300 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#301 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#302 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#303 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#304 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#305 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#306 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#307 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:5251:11) flutter#308 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#309 StatefulElement.update (package:flutter/src/widgets/framework.dart:5274:5) flutter#310 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#311 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#312 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#313 ProxyElement.update (package:flutter/src/widgets/framework.dart:5417:5) flutter#314 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#315 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5111:16) flutter#316 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#317 StatelessElement.update (package:flutter/src/widgets/framework.dart:5162:5) flutter#318 Element.updateChild (package:flutter/src/widgets/framework.dart:3686:15) flutter#319 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1253:16) flutter#320 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1230:5) flutter#321 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1244:7) flutter#322 Element.rebuild (package:flutter/src/widgets/framework.dart:4805:7) flutter#323 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2780:19) flutter#324 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1396:19) flutter#325 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:358:5) flutter#326 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1297:15) flutter#327 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1227:9) flutter#328 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1246:9) flutter#331 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) flutter#332 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1232:27) flutter#333 WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:587:20) flutter#334 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:572:14) flutter#337 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:68:41) flutter#338 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:571:27) flutter#339 main.<anonymous closure>.<anonymous closure> (file:///Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart:15687:20) <asynchronous suspension> <asynchronous suspension> (elided 5 frames from dart:async and package:stack_trace) â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� 00:06 +0 -1: context menu contextMenuBuilder changes from default to null [E] Test failed. See exception logs above. The test description was: contextMenuBuilder changes from default to null To run this test again: /Volumes/MyExternal/ExternalRefCode/flutter/bin/cache/dart-sdk/bin/dart test /Volumes/MyExternal/ExternalRefCode/flutter/packages/flutter/test/material/text_field_test.dart -p vm --plain-name 'context menu contextMenuBuilder changes from default to null' 00:06 +0 -1: Some tests failed. (base) â�� flutter git:(feat/text-field-npe) ``` </details>
godofredoc
pushed a commit
that referenced
this pull request
Aug 14, 2023
This is a follow up to the following pull requests: - flutter#124514 I was finally able to reproduce this bug and found out why it was happening. Consider this code: ```dart GestureDetector( behavior: HitTestBehavior.translucent, // Note: Make sure onTap is not null to ensure events // are captured by `GestureDetector` onTap: () {}, child: _shouldShowSlider ? Slider(value: _value, onChanged: _handleSlide) : const SizedBox.shrink(). ) ``` Runtime exception happens when: 1. User taps and holds the Slider (drag callback captured by `GestureDetector`) 2. `_shouldShowSlider` changes to false, Slider disappears and unmounts, and unregisters `_handleSlide`. But the callback is still registered by `GestureDetector` 3. Users moves finger as if Slider were still there 4. Drag callback is invoked, `_SliderState.showValueIndicator` is called 5. Exception - Slider is already disposed This pull request fixes it by adding a mounted check inside `_SliderState.showValueIndicator` to ensure the Slider is actually mounted at the time of invoking drag event callback. I've added a unit test that will fail without this change. The error stack trace is: ``` The following assertion was thrown while handling a gesture: This widget has been unmounted, so the State no longer has a context (and should be considered defunct). Consider canceling any active work during "dispose" or using the "mounted" getter to determine if the State is still active. When the exception was thrown, this was the stack: #0 State.context.<anonymous closure> (package:flutter/src/widgets/framework.dart:950:9) #1 State.context (package:flutter/src/widgets/framework.dart:956:6) #2 _SliderState.showValueIndicator (package:flutter/src/material/slider.dart:968:18) #3 _RenderSlider._startInteraction (package:flutter/src/material/slider.dart:1487:12) #4 _RenderSlider._handleDragStart (package:flutter/src/material/slider.dart:1541:5) #5 DragGestureRecognizer._checkStart.<anonymous closure> (package:flutter/src/gestures/monodrag.dart:531:53) #6 GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:275:24) #7 DragGestureRecognizer._checkStart (package:flutter/src/gestures/monodrag.dart:531:7) #8 DragGestureRecognizer._checkDrag (package:flutter/src/gestures/monodrag.dart:498:5) #9 DragGestureRecognizer.acceptGesture (package:flutter/src/gestures/monodrag.dart:431:7) #10 _CombiningGestureArenaMember.acceptGesture (package:flutter/src/gestures/team.dart:45:14) #11 GestureArenaManager._resolveInFavorOf (package:flutter/src/gestures/arena.dart:281:12) #12 GestureArenaManager._resolve (package:flutter/src/gestures/arena.dart:239:9) #13 GestureArenaEntry.resolve (package:flutter/src/gestures/arena.dart:53:12) #14 _CombiningGestureArenaMember._resolve (package:flutter/src/gestures/team.dart:85:15) #15 _CombiningGestureArenaEntry.resolve (package:flutter/src/gestures/team.dart:19:15) #16 OneSequenceGestureRecognizer.resolve (package:flutter/src/gestures/recognizer.dart:375:13) #17 DragGestureRecognizer.handleEvent (package:flutter/src/gestures/monodrag.dart:414:13) #18 PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:98:12) #19 PointerRouter._dispatchEventToRoutes.<anonymous closure> (package:flutter/src/gestures/pointer_router.dart:143:9) #20 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) #21 PointerRouter._dispatchEventToRoutes (package:flutter/src/gestures/pointer_router.dart:141:18) #22 PointerRouter.route (package:flutter/src/gestures/pointer_router.dart:127:7) #23 GestureBinding.handleEvent (package:flutter/src/gestures/binding.dart:488:19) #24 GestureBinding.dispatchEvent (package:flutter/src/gestures/binding.dart:468:22) #25 RendererBinding.dispatchEvent (package:flutter/src/rendering/binding.dart:439:11) #26 GestureBinding._handlePointerEventImmediately (package:flutter/src/gestures/binding.dart:413:7) #27 GestureBinding.handlePointerEvent (package:flutter/src/gestures/binding.dart:376:5) #28 GestureBinding._flushPointerEventQueue (package:flutter/src/gestures/binding.dart:323:7) #29 GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:292:9) #30 _invoke1 (dart:ui/hooks.dart:186:13) #31 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:433:7) #32 _dispatchPointerDataPacket (dart:ui/hooks.dart:119:31) Handler: "onStart" Recognizer: HorizontalDragGestureRecognizer#a5df2 ``` *List which issues are fixed by this PR. You must list at least one issue.* Internal bug: b/273666179, b/192329942 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
godofredoc
pushed a commit
that referenced
this pull request
Oct 19, 2023
These values are generated since flutter#135279, but I didn't know to add the new keys to this list to get them to upload. Failed to do so in flutter#135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets. Part of flutter#129150
godofredoc
pushed a commit
that referenced
this pull request
Oct 19, 2023
godofredoc
pushed a commit
that referenced
this pull request
Nov 18, 2023
…lutter#138091) flutter/engine@3e3be5e...117d47a 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from fce71a80b0a2 to a4cce5236dcf (1 revision) (flutter/engine#47807) 2023-11-08 chris@bracken.jp [macOS] Clean up resources in ViewController tests (flutter/engine#47792) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from f3d250126ba9 to fce71a80b0a2 (1 revision) (flutter/engine#47796) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from b4fa927468e6 to f3d250126ba9 (1 revision) (flutter/engine#47793) 2023-11-08 flar@google.com [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate conversion (flutter/engine#47775) 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove Fuchsia Mac SDK from DEPS" (flutter/engine#47791) 2023-11-08 yjbanov@google.com [web] fix clicks on merged semantic nodes (attempt #2) (flutter/engine#47360) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (flutter/engine#47788) 2023-11-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VcFEJiUUTYwkhEAlJ... to sD8HRA4JmXczujkqO... (flutter/engine#47785) 2023-11-08 jiahaog@users.noreply.github.com Fix narrowing conversion lint (flutter/engine#47740) 2023-11-08 chris@bracken.jp [macOS] Bail out of tests if engine not running (flutter/engine#47771) 2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from f91d39395e85 to 0f78e5f765d3 (1 revision) (flutter/engine#47776) 2023-11-08 chris@bracken.jp [testing] Extract StreamCapture test utility (flutter/engine#47774) 2023-11-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Promote fuchsia build v2 to prod." (flutter/engine#47779) 2023-11-08 aam@google.com Include updated locations for dart third_party components into license ignore-list. (flutter/engine#47770) 2023-11-07 chillers@google.com Remove Fuchsia Mac SDK from DEPS (flutter/engine#47700) 2023-11-07 skia-flutter-autoroll@skia.org Roll Skia from 030e21befbc9 to f91d39395e85 (6 revisions) (flutter/engine#47769) 2023-11-07 chinmaygarde@google.com [Impeller] Support static thread safety analysis with condition variables. (flutter/engine#47763) 2023-11-07 godofredoc@google.com Promote fuchsia build v2 to prod. (flutter/engine#47729) 2023-11-07 737941+loic-sharma@users.noreply.github.com [Windows] Reduce warnings produced by unit tests (flutter/engine#47724) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VcFEJiUUTYwk to sD8HRA4JmXcz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
godofredoc
pushed a commit
that referenced
this pull request
Mar 12, 2024
A test was failing silently because of this (see flutter#144353 and fixed in flutter#144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows: ``` 00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following assertion was thrown running a test (but after the test had completed): setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not mounted) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9) #1 State.setState (package:flutter/src/widgets/framework.dart:1202:6) #2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5) <asynchronous suspension> ════════════════════════════════════════════════════════════════════════════════════════════════════ 00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart 00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E] Test failed. See exception logs above. The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart This test failed after it had already completed. Make sure to use a matching library which informs the test runner of pending async work. ```
godofredoc
pushed a commit
that referenced
this pull request
Mar 12, 2024
…r#144706)" (flutter#144970) Reverts: flutter#144706 Initiated by: gspencergoog Reason for reverting: This has broken the tree because some tests are still failing post completion. This particular one looks like it might have to do with a gold image not existing. Original PR Author: goderbauer Reviewed By: {Piinks} This change reverts the following previous change: A test was failing silently because of this (see flutter#144353 and fixed in flutter#144709). The failure went undetected for months. Ideally, this should have been a regular non-silent failure. This change makes that so. `package:test` can properly handle reported exceptions outside of test cases. With this change, the test fails as follows: ``` 00:03 +82: Smoke test material/color_scheme/dynamic_content_color.0.dart ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════ The following assertion was thrown running a test (but after the test had completed): setState() called after dispose(): _DynamicColorExampleState#1cd37(lifecycle state: defunct, not mounted) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1167:9) #1 State.setState (package:flutter/src/widgets/framework.dart:1202:6) #2 _DynamicColorExampleState._updateImage (package:flutter_api_samples/material/color_scheme/dynamic_content_color.0.dart:191:5) <asynchronous suspension> ════════════════════════════════════════════════════════════════════════════════════════════════════ 00:03 +81 -1: Smoke test material/context_menu/context_menu_controller.0.dart 00:03 +81 -1: Smoke test material/color_scheme/dynamic_content_color.0.dart [E] Test failed. See exception logs above. The test description was: Smoke test material/color_scheme/dynamic_content_color.0.dart This test failed after it had already completed. Make sure to use a matching library which informs the test runner of pending async work. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github/codeql-action from 1.1.5 to 2.1.6.
Changelog
Sourced from github/codeql-action's changelog.
... (truncated)
Commits
28eead2Merge pull request #1004 from github/update-v2.1.6-bfe9e810a4da970Run workflow also onv2branch34a1681Fix location of changelog entry8833977Update changelog for v2.1.6bfe9e81Merge pull request #1003 from github/edoardo/fix-workflow1d58cc1Fix typos in release workflowd8576e3Merge pull request #990 from github/edoardo/2.8.4-bumpf1060fbBump default CodeQL version to 2.8.4af34c6dMerge pull request #1002 from github/henrymercer/update-changelog-rewriting282b607Update changelog rewriting step to match v2+ only release notesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)