[flutter_tools] Remove sound null safety flag #120936

christopherfujino · 2023-02-17T01:06:28Z

Remove both the --sound-null-safety and --null-assertions flags from the Flutter CLI tool. These will be removed from the Dart SDK in the 3.0 release. Before this change, we were defaulting to --sound-null-safety and --no-null-assertions, and providing a warning if the user explicitly overrode this that they were going to be deprecated soon.

Note there is no change in this PR related to the --native-null-assertions flag; it defaults to on but the user can explicitly disable it, which is the desired behavior per #118810 (comment).

christopherfujino · 2023-03-07T00:20:25Z

packages/flutter_tools/lib/src/web/bootstrap.dart

@@ -168,7 +167,6 @@ require.config({
 define("$bootstrapModule", ["$entrypoint", "dart_sdk"], function(app, dart_sdk) {
  dart_sdk.dart.setStartAsyncSynchronously(true);
  dart_sdk._debugger.registerDevtoolsFormatter();
-  dart_sdk.dart.nonNullAsserts($nullAssertions);


@nshahan is it ok that I deleted this line? Or should I leave this line and hard-code the value (since I deleted the CLI arg in this PR)?

Yes, looks like good cleanup. This is totally unneeded as long as you are prevented from passing
--no-sound-null-safety when compiling. It will be defaulted to false in the compiled SDK until it is fully cleaned up.

packages/flutter_tools/lib/src/resident_runner.dart

christopherfujino · 2023-03-08T18:24:18Z

FYI @a-siva

zanderso · 2023-03-08T20:29:24Z

packages/flutter_tools/lib/src/artifacts.dart

@@ -91,12 +91,7 @@ enum HostArtifact {
  webPlatformDart2JSSoundKernelDill,

  /// The precompiled SDKs and sourcemaps for web debug builds.
-  webPrecompiledSdk,


Is this cleanup related to the flag removal?

Yeah, these are the unsound parts of the web sdk, which are no longer reachable.

This #122215 is tracking not building it

zanderso · 2023-03-08T20:33:10Z

packages/flutter_tools/lib/src/reporting/events.dart

-    }
-    flutterUsage.sendEvent(kNullSafetyCategory, 'runtime-mode', label: nullSafetyMode.toString());
-    flutterUsage.sendEvent(kNullSafetyCategory, 'stats', parameters: CustomDimensions(
-      nullSafeMigratedLibraries: migrated,


Can these fields be removed from the CustomDimensions class?

ooh, good catch

WDYT about this diff 3519e1f

packages/flutter_tools/lib/src/reporting/custom_dimensions.dart

…-safety-flag

nshahan · 2023-03-16T22:59:24Z

packages/flutter/test_private/bin/test_private.dart

@@ -225,7 +225,7 @@ class TestCase {
    for (final File test in tests) {
      final String testPath = path.join(path.dirname(test.path), 'lib', path.basenameWithoutExtension(test.path));
      final ProcessRunnerResult result = await runner.runProcess(
-        <String>[flutter, 'test', '--enable-experiment=non-nullable', '--null-assertions', testPath],
+        <String>[flutter, 'test', '--enable-experiment=non-nullable', testPath],


Is that non-nullable experiment flag used anymore? If this is the Dart SDK experiment flag it is no longer needed.

ahh, good catch

This reverts commit 7c3088c.

…2909) This reverts commit 7c3088c.

…ter#120936)

…" (#122909)" This reverts commit f6bc147.

…" (#122909)" (#123031) [flutter_tools] Remove sound null safety flag #2

…ter#120936)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 17, 2023

christopherfujino force-pushed the remove-sound-null-safety-flag branch 3 times, most recently from 44f905d to 6338250 Compare February 27, 2023 20:46

christopherfujino marked this pull request as ready for review February 28, 2023 02:19

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Mar 6, 2023

christopherfujino commented Mar 7, 2023

View reviewed changes

nshahan reviewed Mar 7, 2023

View reviewed changes

packages/flutter_tools/lib/src/resident_runner.dart Show resolved Hide resolved

christopherfujino added 21 commits March 7, 2023 12:47

wip

3b04acc

wip moar

d852cbd

moar wip

481a120

moar

f26e2ce

remove accidental log files

30b948b

get working with bad tests

7d2abf3

fix test

59b57e6

fix another test

7ea263b

foo

c2f9260

fix commands hermetic build tests

299808a

fix more tests

be85ead

clean up tests

9e6fec9

delete null safety analytics events

a632971

more migrations (with failing test in devfs_web_test.dart

5e47d5c

more analysis fixes

4a51082

fix more analysis

87c7bb4

more analysis fix

412f2cc

get analysis green

bb32b62

clean up references to --sound-null-safety flag

77e8da1

foo

8a080dd

fix analysis

375d8b6

christopherfujino added 2 commits March 7, 2023 17:35

fix two commands tests

c587ca6

Merge branch 'master' into remove-sound-null-safety-flag

9138e4f

christopherfujino requested a review from zanderso March 8, 2023 18:24

christopherfujino mentioned this pull request Mar 8, 2023

Stop building/uploading unsound web dills #122215

Open

zanderso reviewed Mar 8, 2023

View reviewed changes

deprecate nullsafety custom dimensions

3519e1f

zanderso approved these changes Mar 9, 2023

View reviewed changes

packages/flutter_tools/lib/src/reporting/custom_dimensions.dart Outdated Show resolved Hide resolved

christopherfujino added 5 commits March 8, 2023 16:34

code review

025cd3b

Merge branch 'master' into remove-sound-null-safety-flag

2905131

Merge remote-tracking branch 'upstream/master' into remove-sound-null…

171f14f

…-safety-flag

Merge branch 'master' into remove-sound-null-safety-flag

26c28db

fix another test

2578c20

nshahan reviewed Mar 16, 2023

View reviewed changes

fix more tests

ade3d28

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023

auto-submit bot merged commit 7c3088c into flutter:master Mar 17, 2023
128 checks passed

christopherfujino deleted the remove-sound-null-safety-flag branch March 17, 2023 17:48

christopherfujino added a commit that referenced this pull request Mar 17, 2023

Revert "[flutter_tools] Remove sound null safety flag (#120936)"

c1ee85e

This reverts commit 7c3088c.

christopherfujino mentioned this pull request Mar 17, 2023

Revert "[flutter_tools] Remove sound null safety flag" #122909

Merged

zanderso pushed a commit that referenced this pull request Mar 17, 2023

Revert "[flutter_tools] Remove sound null safety flag (#120936)" (#12…

f6bc147

…2909) This reverts commit 7c3088c.

HansMuller mentioned this pull request Mar 17, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll mentioned this pull request Mar 18, 2023

Roll Flutter from 53dfd23b043f to 6bd2b3ca21cc (17 revisions) flutter/packages#3486

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 18, 2023

7c3088cf2 [flutter_tools] Remove sound null safety flag (flutter/flut…

8f56a8c

…ter#120936)

christopherfujino added a commit that referenced this pull request Mar 20, 2023

Revert "Revert "[flutter_tools] Remove sound null safety flag (#120936)…

472b6ab

…" (#122909)" This reverts commit f6bc147.

christopherfujino mentioned this pull request Mar 20, 2023

[flutter_tools] Remove sound null safety flag #2 #123031

Merged

auto-submit bot pushed a commit that referenced this pull request Mar 20, 2023

Revert "Revert "[flutter_tools] Remove sound null safety flag (#120936)…

f4c3fac

…" (#122909)" (#123031) [flutter_tools] Remove sound null safety flag #2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

7c3088cf2 [flutter_tools] Remove sound null safety flag (flutter/flut…

5195b2f

…ter#120936)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

7c3088cf2 [flutter_tools] Remove sound null safety flag (flutter/flut…

c4d8b27

…ter#120936)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] Remove sound null safety flag #120936

[flutter_tools] Remove sound null safety flag #120936

christopherfujino commented Feb 17, 2023 •

edited

christopherfujino Mar 7, 2023

nshahan Mar 7, 2023

christopherfujino Mar 7, 2023

christopherfujino commented Mar 8, 2023

zanderso Mar 8, 2023

christopherfujino Mar 8, 2023

christopherfujino Mar 8, 2023

zanderso Mar 8, 2023

christopherfujino Mar 8, 2023

christopherfujino Mar 8, 2023

nshahan Mar 16, 2023

christopherfujino Mar 16, 2023

[flutter_tools] Remove sound null safety flag #120936

[flutter_tools] Remove sound null safety flag #120936

Conversation

christopherfujino commented Feb 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christopherfujino commented Mar 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christopherfujino commented Feb 17, 2023 •

edited