Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningless sentence in String.capitalize's description #8043

Closed
mieldepoche opened this issue Sep 25, 2023 · 2 comments · Fixed by godotengine/godot#86639
Closed

Meaningless sentence in String.capitalize's description #8043

mieldepoche opened this issue Sep 25, 2023 · 2 comments · Fixed by godotengine/godot#86639
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug

Comments

@mieldepoche
Copy link

Your Godot version: 4.1.1

Issue description:

image

URL to the documentation page:
https://docs.godotengine.org/en/stable/classes/class_string.html#class-string-method-capitalize

@mieldepoche mieldepoche changed the title meaningless sentence in String.capitalize's description Meaningless sentence in String.capitalize's description Sep 25, 2023
@skyace65
Copy link
Contributor

skyace65 commented Oct 1, 2023

@Mickeon this was a change from when you overhauled string documentation here. The note doesn't make sense to me either. Based on the method description I wouldn't expect it to capitalize fps and give you "FPS", I'd expect it to create "Fps". Is there something we're missing?

@Mickeon
Copy link
Contributor

Mickeon commented Oct 1, 2023

I remember seeing an user that was confused by this behaviour. Unfortunately you'd have to take my word for it because it has been way too long to find it.

What OP is pointing out is a missing "is", which is my typical oopsie.

The note felt important at the time, but do say if it could safely be removed. It is information that you can infer by reading the steps, but some Godot users may misunderstand this as working the way the editor does.

@Piralein Piralein added the area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository label Oct 12, 2023
YuriSizov pushed a commit to YuriSizov/godot that referenced this issue Jan 24, 2024
YuriSizov pushed a commit to YuriSizov/godot that referenced this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants