Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Window command menu on macOS #7768

Closed
valentinegb opened this issue Sep 20, 2023 · 1 comment
Closed

Add the Window command menu on macOS #7768

valentinegb opened this issue Sep 20, 2023 · 1 comment

Comments

@valentinegb
Copy link

valentinegb commented Sep 20, 2023

Describe the project you are working on

This proposal applies to all projects which are being developed on macOS.

Describe the problem or limitation you are having in your project

The essential and standard macOS Window command menu which is expected by all macOS applications does not exist for Godot.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add the Window command menu and its commands.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

The Window command menu would be placed after the Editor menu and before the Help menu, as is convention on macOS. It should contain the Minimize, Zoom, Tile Window to Left of Screen, Tile Window to Right of Screen, Replace Tiled Window, and Remove Window from Set commands.

Screenshot 2023-09-20 at 10 54 46 AM

This mockup was created with SwiftUI, so it would've been a hassle to remove the "Godot" item at the bottom of that Window command menu. I do not intend for that to be part of the proposal. However, it would actually be quite nice and address another issue, #6442.

If this enhancement will not be used often, can it be worked around with a few lines of script?

The proposed changes would not effect anyone who decides not to use the new commands, besides from maybe anyone who maybe clicks the Window command menu accidentally whilst trying to click the Help menu, in which case the only repercussion is a moment of delay.

Is there a reason why this should be core and not an add-on in the asset library?

The Window command menu is standard. It is expected to just be there, for all macOS applications. Users should not have to go out of their way to add basic functionality to Godot.

@bruvzg
Copy link
Member

bruvzg commented Dec 18, 2023

Window menu is added in godotengine/godot#83987

But it won't fix #6442, since it's caused by Godot using multiple process (so it can't be fixed without implementing #8151).

@bruvzg bruvzg closed this as completed Dec 18, 2023
@YuriSizov YuriSizov added this to the 4.3 milestone Dec 18, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants