Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Add default Window menu. #83408

Closed
wants to merge 1 commit into from
Closed

[macOS] Add default Window menu. #83408

wants to merge 1 commit into from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 15, 2023

@bruvzg bruvzg added this to the 4.x milestone Oct 15, 2023
@bruvzg bruvzg requested a review from a team as a code owner October 15, 2023 18:06
@lostminds
Copy link

If this will now populate with all app windows (for multi-window projects), it might be an idea to add the excludedFromWindowsMenu flag to popup windows like AcceptDialog (maybe all windows with the Window.popup_window flag set?) to prevent them from appearing in the menu automatically.

@bruvzg
Copy link
Member Author

bruvzg commented Oct 21, 2023

it might be an idea to add the excludedFromWindowsMenu flag to popup windows like AcceptDialog (maybe all windows with the Window.popup_window flag set?) to prevent them from appearing in the menu automatically.

This is a good idea, added it for windows with popup and no focus (tooltips) flags.

@bruvzg bruvzg mentioned this pull request Oct 26, 2023
Merged
@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 18, 2023 •
edited
Loading

Is this superseded by #83987? Also the proposal is different from the one closed by the other PR, but looks like a duplicate. Should it also be closed?

@bruvzg
Copy link
Member Author

bruvzg commented Dec 18, 2023

Is this superseded by #83987?

Yes.

@bruvzg bruvzg closed this Dec 18, 2023
@YuriSizov YuriSizov removed this from the 4.x milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived enhancement platform:macos topic:porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @lostminds @YuriSizov