Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic swipes/gestures as InputEvents (InputEventGesture) #1319

Closed
adolson opened this issue Jan 30, 2015 · 15 comments
Closed

Add generic swipes/gestures as InputEvents (InputEventGesture) #1319

adolson opened this issue Jan 30, 2015 · 15 comments

Comments

@adolson
Copy link
Contributor

adolson commented Jan 30, 2015

add generic swipes as actions in the action editor

https://www.facebook.com/groups/godotengine/permalink/563740600429205/

@reduz
Copy link
Member

reduz commented Jan 30, 2015

Thanks!
On Jan 30, 2015 1:03 PM, "adolson" notifications@github.com wrote:

add generic swipes as actions in the action editor

https://www.facebook.com/groups/godotengine/permalink/563740600429205/


Reply to this email directly or view it on GitHub
#1319.

@florix91
Copy link

Would this be made for 2.1? Strange that has not been made till now. I would like to help but don't really have the ability at the moment...

@reduz
Copy link
Member

reduz commented Jun 22, 2016

we could add this as an add-on now that we have the asset library

@akien-mga
Copy link
Member

There's a plugin for this on the Asset Library, though I haven't tested it: https://godotengine.org/asset-library/asset/23

Do we want to keep this issue open for the possibility to add something to the InputEvent API directly, or should we close it and let community plugins handle those use cases?

@vnen
Copy link
Member

vnen commented Jun 28, 2017

I still want InputEventGesture as commented in #9115 (comment)

@akien-mga akien-mga changed the title add generic swipes as actions in the action editor Add generic swipes/gestures as InputEvents Jun 29, 2017
@akien-mga akien-mga changed the title Add generic swipes/gestures as InputEvents Add generic swipes/gestures as InputEvents (InputEventGesture) Aug 30, 2017
@akien-mga
Copy link
Member

See #9115 for an example implementation (rejected, as not cross-platform) of touchpad pinch zooming for OSX.

To have a mergeable implementation, we'd need it to fulfill those requirements:

  • It should be based on a new InputEventGesture class
  • It should be supported on all platforms where it's relevant (at least all desktop platforms, then eventually also mobile ones)

Feel free to split the work in several PRs (a first one could add the InputEventGesture class and support for e.g. pinch gestures, follow-ups could add support for swipe, tap, etc.).

@toger5
Copy link
Contributor

toger5 commented Aug 30, 2017

I posted a proposal about the implementation of Gestures + mouse events in general.

#9136

Although this one is more about MouseGestures. Not touch screen.

@raymoo
Copy link
Contributor

raymoo commented Aug 30, 2017

@akien-mga Multitouch isn't even supported on desktop platforms, wouldn't that be a prerequisite of some gestures, like zoom or rotate?

@akien-mga
Copy link
Member

Well it definitely is at least for laptops with a decent touchpad with decent drivers, and for touch screens.

@reduz
Copy link
Member

reduz commented Aug 30, 2017 via email

@raymoo
Copy link
Contributor

raymoo commented Aug 31, 2017

@akien-mga @reduz does that mean #7612 and #8028 can be closed?

@akien-mga
Copy link
Member

Well they're both prerequisites of this issue. I guess it makes sense to ensure first that desktop platforms support multitouch (#8028), and then implement a common gesture interface in core for all platforms (this issue).

@raymoo
Copy link
Contributor

raymoo commented Aug 31, 2017

If I was unclear earlier I meant that Godot doesn't support multitouch on those platforms.

@samvila
Copy link
Contributor

samvila commented Sep 6, 2017

@reduz Please bring multi-touch to Windows and Linux, I'm trying to convince my boss to move from Unreal to Godot at work but not having multi-touch is blocking the move. If Someone is interested I could provide a testing platform and work with him/her to make sure the integration is good.

@akien-mga
Copy link
Member

Base API is implemented in #12573, it still needs to be implemented on non-macOS (see #13139), and maybe more types of gestures could be added if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants