Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving folder AA to folder BB which have folder with same name(AA) cause error moving instead merge. #22850

Open
qarmin opened this issue Oct 8, 2018 · 1 comment

Comments

@qarmin
Copy link
Contributor

qarmin commented Oct 8, 2018

Godot version:
3.1 b17e71b

Windows 10

Issue description:
When I try to copy folder with name AA to folder BB which contain folder with name AA, error "Error moving:" was occur.

I think that Godot should merge this folder to one.

When we paste files, the warning message should stay as is "Please Confirm... ... Overwrite Cancel "

But when we paste folders, I think the warning should change text "Overwrite" to "Merge and Overwrite".

Steps to reproduce:

  1. Create res://AA folder
  2. Create res://BB folder
  3. Create res://BB/AA folder
  4. Try to cut folder res://AA and paste it to res://BB

https://streamable.com/vibga

@qarmin qarmin changed the title Moving folder AA to folder BB which folder with same name(AA) cause error moving instead merge. Moving folder AA to folder BB which have folder with same name(AA) cause error moving instead merge. Oct 8, 2018
@akien-mga akien-mga added this to the 3.1 milestone Oct 19, 2018
@akien-mga akien-mga modified the milestones: 3.1, 3.2 Dec 14, 2018
@akien-mga
Copy link
Member

To anyone interested in implementing this, please take the feedback in #22855 into account.

Especially, there should be a confirmation dialog before any kind of merge or overwrite operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants