Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite3D covers editor icons disregarding depth #24069

Closed
KoBeWi opened this issue Nov 29, 2018 · 9 comments · Fixed by #91174
Closed

Sprite3D covers editor icons disregarding depth #24069

KoBeWi opened this issue Nov 29, 2018 · 9 comments · Fixed by #91174
Labels
bug confirmed topic:editor topic:rendering topic:3d
Milestone
4.3

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 29, 2018

Godot version:
3.1 alpha2

Issue description:
image
image
The light is in front of Sprite3D, but the icon gets covered when you look from the front.

Minimal reproduction project:
TestProject.zip
@CptPotato
Copy link
Contributor

CptPotato commented Nov 30, 2018 •
edited

Does this also happen when they are further apart? If not it's probably related to z-sorting in which case there may not be a perfect solution.

Looks like my assumption was wrong.

@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 30, 2018

Seems to be happening on any distance.

@JFonS JFonS self-assigned this Nov 30, 2018
@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 29, 2020

Still valid in 3.2.2

@Calinou
Copy link
Member

Calinou commented Jul 6, 2020 •
edited

If you can build Godot from source, please build the 3.2 branch and test this again now that #39867 has been merged. (That pull request also makes Sprite3D much faster to render.)

You can also use this Windows 64-bit editor binary for testing.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 6, 2020

Still not fixed, tested with the provided binary.

@KoBeWi KoBeWi mentioned this issue Aug 16, 2021
Closed
@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 14, 2022

Still valid in 39534a7

@Calinou
Copy link
Member

Calinou commented Oct 14, 2022 •
edited

This can likely be fixed by changing 3D editor gizmo icons' alpha mode to Opaque Prepass (or Alpha Cut, but it'll cause visible aliasing unless TAA or FXAA are enabled).

CoolDotty added a commit to CoolDotty/godot that referenced this issue Apr 26, 2023
@CoolDotty
Fix Sprite3D to utilize 3D space by default
e3de2f1 
Changes Sprite3D to use the depth prepass by default instead of render order. This makes Sprite3D more in line with its usage as a helper "to display a 2D texture in a 3D environment".

Fixes godotengine#17567, godotengine#24069
@CoolDotty CoolDotty mentioned this issue Apr 26, 2023
Open
CoolDotty added a commit to CoolDotty/godot that referenced this issue Apr 26, 2023
@CoolDotty
Fix Sprite3D to utilize 3D space by default
d7fb537 
Changes Sprite3D to use the depth prepass by default instead of render order. This makes Sprite3D more in line with its usage as a helper "to display a 2D texture in a 3D environment".

Fixes godotengine#17567, godotengine#24069
@Rindbee
Copy link
Contributor

Rindbee commented May 23, 2023

Still valid in in v3.5.2.stable.official [170ba33] and v4.0.stable.official [92bee43].

@Calinou Calinou mentioned this issue Oct 1, 2023
Closed
@Calinou Calinou mentioned this issue Oct 1, 2023
Closed
@lorenzokerbrat
Copy link

Still valid in v4.2.beta3 [e8d57af]

@Calinou Calinou mentioned this issue Apr 25, 2024
Merged
@akien-mga akien-mga added this to the 4.3 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:editor topic:rendering topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Tweak appearance of 3D editor gizmo icons Calinou/godot
7 participants
@Calinou @KoBeWi @CptPotato @JFonS @akien-mga @Rindbee @lorenzokerbrat