FileDialog current_* values should not be saved to scene files

[aaronfranke]

Godot version: 3.1.1

Issue description:

The FileDialog node has a few string properties called current_dir, current_file, and current_path. These are fine to generate on the fly and use while the game is running, but they should not be saved to .tscn or similar files. Every system that this project is opened on will change this path to be something else. If we really need to save it, then save it inside the .godot folder.

Minimal reproduction project:

The problem is visible here: godotengine/godot-demo-projects#89 (comment)

[Xrayez]

Likely yes, because when you switch mode, those properties are reset automatically AFAIK (current_dir becomes res:// if you switch mode to Resource, for instance). Could also be problematic for tool scripts.

[MatteoPiovanelli-Laser]

Hello. I think this is still an issue now in Godot 3.2.3
See this other issue I opened on a Godot project before finding this thread: #29674

Having those properties automatically save in the .tscn file is troublesome for VCS.

[andrea-calligaris]

This is a security/privacy concerning bug.
Someone please delete the "enhancement" tag and put e.g. "high priority".

[Calinou]

This is a security/privacy concerning bug. Someone please delete the "enhancement" tag and put e.g. "high priority".

If you consider your real name to be sensitive information, don't use your real name as your PC username. I know it requires a fair amount of work to move everything, but it's worth it in the long run 🙂

This way, you also won't have to edit screenshots and logs when posting them online.

[Zireael07]

@Calinou: Counterargument: it's fairly easy to edit screenshots and logs when posting. On the other hand, you can't edit these fields without breaking stuff.

Also, many companies require user name to be your real name, end of story - they won't let you change.

[andrea-calligaris]

If you consider your real name to be sensitive information, don't use your real name as your PC username. I know it requires a fair amount of work to move everything, but it's worth it in the long run slightly_smiling_face

As you can see I have my real name in this GitHub account, so it's not about me: it's about the fact that the bug described in this issue saves an entire path in the scene file. It's not about the name of the PC account, it's about any other folder, any other content that you can browse on your computer. Let's say that for whatever reason, for testing your game you traverse a path on your PC named /home/JohnSmith/Documents/MyVerySecretProjectAboutSomething/secret_information_about_XYZ.txt, that path will be saved in the scene file. That, as I pointed out, is a security/privacy concerning bug.