Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on project initialization: Property not found: mono/editor/editor_path_optional #36995

Closed
MirrasHue opened this issue Mar 11, 2020 · 18 comments · Fixed by #37210
Closed

Comments

@MirrasHue
Copy link

MirrasHue commented Mar 11, 2020

Godot version: 3.2.1-stable_mono_win64

OS/device including version: Win10 1909

Issue description: Godot is trying to find a property, but it is failing to do so

Steps to reproduce: Just edit a project

editor/editor_settings.cpp:151 - EditorSettings::_get - Property not found: mono/editor/editor_path_optional

Minimal reproduction project: Sorry, I didn't get this field's gist

@MirrasHue MirrasHue changed the title Warning on initialization Warning on project initialization Mar 11, 2020
@rsubtil
Copy link
Contributor

rsubtil commented Mar 12, 2020

editor_path_optional looks like an optional path to an editor for you to edit C# code. This doesn't look like a problem.

Here: https://docs.godotengine.org/en/3.2/getting_started/scripting/c_sharp/c_sharp_basics.html#configuring-an-external-editor

@aaronfranke
Copy link
Member

Please provide a minimal reproduction project. I edit projects all the time and don't have this issue.

@MirrasHue
Copy link
Author

MirrasHue commented Mar 13, 2020

Trying to get rid of this warning, I cleaned all godot files, even those from appdata. I'll remove them again and download 3.2 to see if the warning persist, then I'll come back to update you.

@MirrasHue
Copy link
Author

Oh, nothing appeared in 3.2. Regarding what our friend Ricardo said, seems not to be the case, in 3.2.1 I had already chosen vscode as the default editor for c#, and now back in 3.2 this wasn't necessary.

@MirrasHue
Copy link
Author

I tested it out on my college's pc, unfortunately the same warning was showing up.

@MirrasHue
Copy link
Author

Should I close this?

@aaronfranke
Copy link
Member

Feel free to continue the discussion, specifically if you find a reliable way to reproduce it. You should also test on Linux to see if it's an OS-specific issue.

@MirrasHue
Copy link
Author

Sorry, I thought that it was clear that there's simply nothing to reproduce it, I just open a project and the warning is there. Have a good day.

@MirrasHue
Copy link
Author

But it's not harmful to the workflow, just odd to occur every time.

@akien-mga
Copy link
Member

akien-mga commented Mar 20, 2020

You can remove your %APPDATA%/Godot/editor_settings-3.tres to fix it (or just remove the line setting this invalid option).

@akien-mga akien-mga added this to the 4.0 milestone Mar 21, 2020
@akien-mga
Copy link
Member

Actually it's probably related to f0b63b4, CC @van800.

@akien-mga akien-mga reopened this Mar 21, 2020
@akien-mga akien-mga changed the title Warning on project initialization Warning on project initialization: Property not found: mono/editor/editor_path_optional Mar 21, 2020
@van800
Copy link
Contributor

van800 commented Mar 21, 2020

Hm. I can't reproduce it, even if mono/editor/editor_path_optional is not initialized in settings. Ah, might be windows-only issue. I can't start Rider on Windows machine remotely, so I might not be able to reproduce and fix.

@neikeq As far as I understand, managed stacktraces are not printed to GD output together with unmanaged exception. Is it printed elsewhere maybe?

@van800
Copy link
Contributor

van800 commented Mar 21, 2020

@MirrasHue Do you use Rider?

@MirrasHue
Copy link
Author

@van800 No, I use vscode

@akien-mga Is this a regression? In 3.2 this doesn't happen.
And I removed that setting from %appdata%, nothing changed.

I wonder if everybody in this issue is using the mono version.

@van800
Copy link
Contributor

van800 commented Mar 21, 2020

Reproduced. I hope to have a fix shortly.

@akien-mga
Copy link
Member

@MirrasHue It was a regression from f0b63b4, but it's harmless. It's just that it could now happen that the MSBuild detection code queries this Rider-specific parameter, which may not be defined if you didn't configure Godot to work with Rider. #37210 fixes it.

@MirrasHue
Copy link
Author

@van800 Oh, now I see, when we select Rider a new option appear, but for vscode it doesn't.

Unlike 3.2, 3.2.1 can't figure out the path automatically, so that's why this 'mono/editor/editor_path_optional' is not in my 'editor_settings-3.tres'.

@MirrasHue
Copy link
Author

After switching back the External Editor to vscode, the Editor Path Optional property kept there, so I put the absolute path to Code.exe and seems to work just fine, no more warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants