Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"(Unsaved changes will be lost)" is too frightening #4731

Closed
SuperUserNameMan opened this issue May 20, 2016 · 8 comments
Closed

"(Unsaved changes will be lost)" is too frightening #4731

SuperUserNameMan opened this issue May 20, 2016 · 8 comments

Comments

@SuperUserNameMan
Copy link
Contributor

Operating system or device - Godot version:
Any version of Godot since at least 1.0betaxx on any platform

Issue description (what happened, and what was expected):
When you quit the editor to project list, there is this nightmarish dialog box asking you to confirm :

Please Confirm...x
Open Project Manager ?
(Unsaved changes will be lost)
[QUIT (and do nightmares)] [Cancel (if you're too afraid to quit)]

It would be cool if instead of terrorizing us, the editor was kind enough to tell us what file are not save when files are not saved.

On the other hand, when you just Quit, there is no such warning.

Steps to reproduce:
Quit to the project list.

Link to minimal example project (optional but very welcome):

@Marqin
Copy link
Contributor

Marqin commented May 21, 2016

It looks like https://github.com/godotengine/godot/blob/master/tools/editor/editor_node.cpp#L2686 doesn't have any check if there are not saved files/scenes:

case RUN_PROJECT_MANAGER: {

    if (!p_confirmed) {
        confirmation->get_ok()->set_text(TTR("Yes"));
        confirmation->set_text("Open Project Manager? \n(Unsaved changes will be lost)");
        confirmation->popup_centered_minsize();
        break;
    }

(or maybe it's set in that p_confirmed)

@bojidar-bg
Copy link
Contributor

The Scene close function does it this way:

if (!p_confirmed && unsaved_cache) {
    confirmation->get_ok()->set_text(TTR("Yes"));
    //confirmation->get_cancel()->show();
    confirmation->set_text(TTR("Close scene? (Unsaved changes will be lost)"));
    confirmation->popup_centered_minsize();
    break;
}

_remove_edited_scene();

@balloonpopper
Copy link

Ideally I'd like to see the exit dialog aware of whether there's outstanding changes, but if this isn't feasible, how about a 3 option window with
Open project manager?

  1. Yes (Saves all scenes)
  2. Yes (Lose any changes)
  3. Cancel

@bojidar-bg
Copy link
Contributor

@balloonpopper Sounds cool, though it might be better named as:

  1. Save changes (the changes part can be dropped)
  2. Discard changes
  3. Cancel
    Since, having two "Yes" buttons is terrible in general.

@ghost
Copy link

ghost commented Jul 24, 2017

Fixed by #9304?

@akien-mga akien-mga added this to the 3.0 milestone Jul 24, 2017
@b-hayes
Copy link

b-hayes commented May 11, 2020

I had this issue too where my system failed to update because Godot blocked a shutdown because it was open with no changes to be saved at all.

It should just allow the OS to close it if there are no changes.

@bojidar-bg
Copy link
Contributor

@b-hayes This issue has been considered fixed for the better part of the last 3 years. I would suggest opening a new issue describing the problem you are having instead of bumping this one 😃

@Calinou
Copy link
Member

Calinou commented May 11, 2020

@b-hayes #32321 will address this if it's merged. You can already disable the quit confirmation in the Editor Settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants