Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: strange SSAO artifacts on flat surfaces #66643

Closed
atirut-w opened this issue Sep 30, 2022 · 7 comments · Fixed by #73420
Closed

Vulkan: strange SSAO artifacts on flat surfaces #66643

atirut-w opened this issue Sep 30, 2022 · 7 comments · Fixed by #73420

Comments

@atirut-w
Copy link
Contributor

Godot version

v4.0.beta2.official [f8745f2]

System information

Arch Linux, Vulkan Clustered, Nvidia 1660(Nvidia open driver 515.76-2)

Issue description

I initially thought this has something to do with the SSAO half size issues(#59471, #51564 (comment)), but I found out that disabling half size only made the issue more subtle.

Personally, I think these issues have the same cause issue and the disabling of half size fixing them is due to how subtle the artifacts become after disabling half size.

2022-09-30.10-39-44.mp4

Steps to reproduce

  1. Set up a scene with a flat surface(cube, plane, etc.)
  2. Enable SSAO

Minimal reproduction project

SSAO Issue.zip

@Calinou Calinou added this to the 4.0 milestone Sep 30, 2022
@clayjohn clayjohn modified the milestones: 4.0, 4.x Jan 12, 2023
@Flavelius
Copy link
Contributor

This is still an issue (for me atleast) in 4.0 beta15. As a kind-of workaround the negative effect can be toned down by increasing the ao radius.

@atirut-w
Copy link
Contributor Author

@clayjohn does this issue getting moved to 4.x imply that 4.0 will be released with SSAO broken like this?

@clayjohn
Copy link
Member

@clayjohn does this issue getting moved to 4.x imply that 4.0 will be released with SSAO broken like this?

No. 4.x includes 4.0. if someone fixes this before we release 4.0 then it will be in the 4.0 release

@atirut-w
Copy link
Contributor Author

Why move it then?

@Flavelius
Copy link
Contributor

Why move it then?

Because it's probably not a showstopper for the 4.0 release. It can be fixed and as said will be included if it is, but does not have to be for 4.0 to be released.

@BastiaanOlij
Copy link
Contributor

This could be fixed by #72838, no guarantees though as I haven't seen this behavior before.

@mrjustaguy
Copy link
Contributor

This wasn't fixed by it, this seems to have something to do with the depth, as it appears and disappears as you change your distance from the surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants