Fix sampling bug when SSAO is using half size #73420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62881
Fixes: #66643
There are two pieces to this PR:
half_screen_pixel_size
to be based off the full screen size / 2. This was a difficult bug to track down, but essentially when using a screen size that could not be subdivided cleanly 4 times the half res samples would drift away from their intended positions. To fix that, we base our scaling off of the full viewport size.This also cleans up two unreported bugs:
Finally, on investigation it appears that SSIL was suffering from the same issues, it was just less obvious. So I made the changes to SSIL as well
Before
After
Before
After