Adding version info to GDNative ARVR interfaces #19171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
add_arvr_interface_gdnative_version
branch
from
ce9b7d2
to
ea9eb5e
Compare
BastiaanOlij
force-pushed
the
add_arvr_interface_gdnative_version
branch
from
ea9eb5e
to
70bb158
Compare
BastiaanOlij
changed the title
This was referenced May 26, 2018
BastiaanOlij
force-pushed
the
add_arvr_interface_gdnative_version
branch
from
70bb158
to
8901b3c
Compare
|
Would have been good to edit the commit log, merging a commit with |
|
ARGH! sorry @akien-mga , completely missed that I hadn't changed that.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been holding off adding new calls to the ARVR interface because we had no sure way to test if the plugin had support for any new calls. Because we hadn't added this for the 3.0 release it would always mean a breaking change.
I've added a type field and a version field at the top of the structure. The type field just makes it easier to detect when we have a pointer to an interface written for Godot 3.0 as the pointer of the constructor is unlikely to ever spell ARVR, the version will allow us to detect whether new features are supported by the plugin.
For testing and seeing what changes are required I have updated the ARVRSimple reference implementation to perform all the required version checks:
BastiaanOlij/ARVRSimple#4