Android platform dependent entry points for GDNative #19591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
reviewed
Jun 16, 2018
|
|
||
| #include "modules/gdnative/gdnative.h" | ||
|
|
||
| // nothing to declare here at the moment, for now there are only entry calls |
There was a problem hiding this comment.
Why is this file here? I guess it was generated by an IDE? :D In all other GDNative "submodules" the implementation files don't have the headers in the same place, so I don't see why this file is needed.
Maybe there are some plans for later, but it just seems like boilerplate right now.
There was a problem hiding this comment.
Bump, once this file is removed it can be merged.
There was a problem hiding this comment.
I originally started in a different direction, yeah I'll clean it up :)
BastiaanOlij
force-pushed
the
gdnative_android
branch
from
c3531bc
to
1697cbb
Compare
BastiaanOlij
changed the title
karroffel
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reworked a few calls @Paritosh97 created to give access to a few android internals that are needed in Android gdnative modules.
We may change/add more as we try to get our GearVR code to work :)