Remove unneeded strncpy in lws_client. #23241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the String buffer directly, lws_client_connect_via_info will copy them for us.
Empty of course as server is not supported in HTML5, but the symbol must be defined.
|
Also add missing definition of |
|
Thanks! |
Faless
added a commit
to Faless/godot
that referenced
this pull request
Nov 3, 2018
I was wrong in assuming that String had to survive long enough to avoid it, what actually needed to survive was the CharString obtained from the acsii() or utf8() function. At least according to valgrind
akien-mga
added a commit
that referenced
this pull request
Nov 10, 2018
Fix access to freed mem in WS client after #23241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the String buffer directly,
lws_client_connect_via_infowill copy them for us.Closes #23236
Fixes #23141
Edit: Also add missing definition of
EMWSServer::pollin ref to #23005