Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows user to click on error line in status bar to jump into error. #23875

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Nov 21, 2018

Its a bit of useful functionality, it makes the error line in the script editor(and shader editor too) clickable and allow user to quickly jump into error.

image

I changed line type to LinkButton and the only downside about this approach is if this is long error line, the editor will try to expand itself(instead of clip or autowrap). Leave a suggestions of how to fix it..

@Chaosus Chaosus changed the title Allows user to click on error line to jump into error. Allows user to click on error line in status bar to jump into error. Nov 21, 2018
@Chaosus Chaosus added this to the 3.1 milestone Nov 21, 2018
@groud
Copy link
Member

groud commented Nov 21, 2018

You need to encompass the LinkButton into a normal Control node, set its margins / archors to full wide preset and with clip content active.

@Chaosus
Copy link
Member Author

Chaosus commented Nov 21, 2018

@groud Done !

@Chaosus Chaosus force-pushed the error_btn branch 3 times, most recently from 4cb152e to 429edfa Compare November 22, 2018 05:46
@Chaosus
Copy link
Member Author

Chaosus commented Nov 22, 2018

I've added tooltip to this line in order to allow user to see full line if the error is too long and cropped

@akien-mga akien-mga merged commit edbecf5 into godotengine:master Nov 22, 2018
@akien-mga
Copy link
Member

Looks nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants