Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Add support for x86_64 architecture #25033

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
1 participant
@akien-mga
Copy link
Member

commented Jan 16, 2019

Part of #25030.

Should be cherry-picked for both 3.0 and 2.1 as per the new Google policy outlined in #25030.

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Note: Don't merge just yet, I'm still building locally to make sure that it works. I'll update this comment once it's confirmed.

Update: Builds and exports successfully locally.

@akien-mga akien-mga force-pushed the akien-mga:android-x86_64 branch from f18febf to 2c23536 Jan 16, 2019

Android: Add support for x86_64 architecture
Like arm64v8, this is only supported by API 21 and later,
so we enforce 21 as min API for x86_64.

Part of #25030.

@akien-mga akien-mga force-pushed the akien-mga:android-x86_64 branch from 2c23536 to 7f4ee36 Jan 16, 2019

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Like arm64v8, this is only supported by API 21 and later, so we enforce 21 as min API for x86_64.

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Tested that it builds and exports fine on my Linux system against NDK r18. I could not test the resulting APK though as I don't have any x86_64 Android device.

@akien-mga akien-mga merged commit 72bfd10 into godotengine:master Jan 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@akien-mga akien-mga deleted the akien-mga:android-x86_64 branch Jan 16, 2019

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

@hpvb Please add android_arch=x86_64 builds to your build script for 3.1.

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Cherry-picked for 3.0.7.

@akien-mga

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Cherry-picked for 2.1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.