Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back libwebsockets to version 3.0.1 #28568

Merged
merged 1 commit into from May 2, 2019

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented May 1, 2019

This reverts commit 90210c4.

Fixes #27560 while we transition to wslay (a potential cherry pick for godot 3.1.2).

I would like interested parties to test this a bit before we decide what to do (@AshfordN , @RyanJEC, ...).

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me as currently we can't build distro packages against system libwebsockets anyway due to the messy openssl-to-mbedtls wrapper.

@akien-mga akien-mga added this to the 3.2 milestone May 1, 2019
@AshfordN
Copy link

AshfordN commented May 1, 2019

I've tested this and, as far as I can see, it seems to be working perfectly.

@ghost
Copy link

ghost commented May 1, 2019

Tested, confirmed wss://echo.websocket.org is no longer disconnecting along with my custom websocket server.

However still getting immediate disconnect using wss://irc-ws.chat.twitch.tv Hopefully this will be fixed further after wslay transition.

All in all good patch/revert.

@AshfordN
Copy link

AshfordN commented May 1, 2019

@RyanJEC are you certain your twitch disconnect is actually caused by the connection: close header? Websocket connections are also dropped due to incorrect protocol(s) as well. I'm assuming a service like twitch might define its own protocol, so it might be useful to double check.

@ghost
Copy link

ghost commented May 1, 2019

@AshfordN Honestly I don't know what is going on with twitch ws server. All I know is it connects no problem with browser implementation. I'll probably just use TCP or godot twitch plugin.

I would investigate it but I don't know where or how to start.

This patch works with most servers now. That's all that matters.

@akien-mga akien-mga merged commit b7cd979 into godotengine:master May 2, 2019
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocketClient closes connection soon after handshake with some server implementations
3 participants