New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll back libwebsockets to version 3.0.1 #28568
Conversation
This reverts commit 90210c4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me as currently we can't build distro packages against system libwebsockets anyway due to the messy openssl-to-mbedtls wrapper.
I've tested this and, as far as I can see, it seems to be working perfectly. |
Tested, confirmed wss://echo.websocket.org is no longer disconnecting along with my custom websocket server. However still getting immediate disconnect using wss://irc-ws.chat.twitch.tv Hopefully this will be fixed further after wslay transition. All in all good patch/revert. |
@RyanJEC are you certain your twitch disconnect is actually caused by the |
@AshfordN Honestly I don't know what is going on with twitch ws server. All I know is it connects no problem with browser implementation. I'll probably just use TCP or godot twitch plugin. I would investigate it but I don't know where or how to start. This patch works with most servers now. That's all that matters. |
Thanks! |
Cherry-picked for 3.1.2. |
This reverts commit 90210c4.
Fixes #27560 while we transition to
wslay
(a potential cherry pick for godot3.1.2
).I would like interested parties to test this a bit before we decide what to do (@AshfordN , @RyanJEC, ...).