Basic functionalities for LSP Server #31937
Geequlim left a comment
The signatureHelper looks ok.
For documentations of builtin symbols
I'm not sure this is a good way to implement the builtin documentation support.
You dumping the documentaions of builtin symbols to markdown files from the DocData on the server side and display them in the client side. There would be a lot of markdown files in the output folders so we have to manage the versions and make sure they are not deleted by users. That is not so reliable IMO.
I suggest you send documentations in realtime from the server side every time the client request the documentation display (maybe format them to markdown before send). The the client decide how to display the recived data (may caching and open them as markdown file like you did or something else).
You'd better seperate the signatureHelp and documentLink from the markdown documentation code to different PRs.