Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix crash on iOS 13 #33154
fix crash on iOS 13 #33154
Conversation
This comment has been minimized.
This comment has been minimized.
Could you rebase the branch to remove the unnecessary merge commit? (just |
This comment has been minimized.
This comment has been minimized.
Still needs a rebase to squash commits, otherwise changes seem OK if others can confirm that it fixes the bug without introducing performance regressions. |
This comment has been minimized.
This comment has been minimized.
gerald1248
commented
Nov 4, 2019
@akien-mga which benchmark should we use? I have built iphone.zip with and without the change. I'm happy to run a comparison. I'm not 100% confident performance is the same (I get weird dropped frames sometimes, but perhaps they were an issue before and I didn't notice?) but the thing is that this addresses a bug that's pretty serious. Every Godot app on iOS13 crashes every time it is closed. |
This comment has been minimized.
This comment has been minimized.
Pushed a rebased commit that should be fine to merge.
I'm not sure, but I guess the changes should be fine. The only performance-impacting change now is the reintroduction of the |
This comment has been minimized.
This comment has been minimized.
Thanks! |
This comment has been minimized.
This comment has been minimized.
Cherry-picked for 3.1.2. |
This comment has been minimized.
This comment has been minimized.
Cherry-picked for 3.0.7. |
ealataur commentedOct 29, 2019
•
edited by akien-mga
Fix crash on iOS 13 when app go to background and back it from
Bugsquad edit: Fixes #7966.