SCons: Split libmodules.a in folder-based libs #35982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
scons-modules-enabled-header-and-split
branch
from
62e5ba8
to
575aa32
Compare
This removes the need for the hacky split_libmodules logic on Windows, since all libs are now of manageable size.
akien-mga
force-pushed
the
scons-modules-enabled-header-and-split
branch
from
575aa32
to
4e2dbb1
Compare
|
Tested successfully with:
|
|
I'll wait a day or two before merging this one, so that #35963 can get wider testing in the master branch before adding the lib splitting on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for the hacky split_libmodules logic on Windows,
since all libs are now of manageable size.
Includes #35963 which should be merged first, then this can be rebased.