Improve UX of drive letters (3.2) #36639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Mar 4, 2020
RandomShaper
force-pushed
the
imvu/improve_drives_ux_3.2
branch
5 times, most recently
from
edc9ccb
to
fe8229a
Compare
RandomShaper
force-pushed
the
imvu/improve_drives_ux_3.2
branch
from
fe8229a
to
dba34cc
Compare
RandomShaper
force-pushed
the
imvu/improve_drives_ux_3.2
branch
2 times, most recently
from
9b0ea8f
to
ef4537c
Compare
Namely, move the drive dropdown to just the left of the path text box and don't include the former in the latter. This improves the UX on Windows. In the UNIX case, since its concept of drives is (ab)used to provide shortcuts to useful paths, its dropdown is kept at the original location.
RandomShaper
force-pushed
the
imvu/improve_drives_ux_3.2
branch
from
ef4537c
to
6105dfd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of #36069 for 3.2.
This code is generously donated by IMVU,