Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete enums #37693

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

lupoDharkael
Copy link
Contributor

No description provided.

@lupoDharkael lupoDharkael changed the title Remove PROPERTY_HINT_SPRITE_FRAME Remove obsolete enums Apr 8, 2020
@Chaosus Chaosus added this to the 4.0 milestone Apr 8, 2020
@lupoDharkael lupoDharkael force-pushed the remove-hint branch 2 times, most recently from 5047680 to 1b4e2d3 Compare April 8, 2020 18:02
@lupoDharkael
Copy link
Contributor Author

Sorry for multiple pushes but master introduced conflicts and I messed up xD

Comment on lines 98 to 103
GODOT_PROPERTY_USAGE_NO_INSTANCE_STATE = 512,
GODOT_PROPERTY_USAGE_RESTART_IF_CHANGED = 1024,
GODOT_PROPERTY_USAGE_SCRIPT_VARIABLE = 2048,
GODOT_PROPERTY_USAGE_STORE_IF_NULL = 4096,
GODOT_PROPERTY_USAGE_ANIMATE_AS_TRIGGER = 8192,
GODOT_PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED = 16384,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wrong, the values have to stay in sync with the ones in core/object.h.

@akien-mga akien-mga merged commit d41444b into godotengine:master Apr 10, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants