Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] Add GLTF light import #39428

Merged
merged 1 commit into from Jun 11, 2020
Merged

[3.2] Add GLTF light import #39428

merged 1 commit into from Jun 11, 2020

Conversation

fire
Copy link
Member

@fire fire commented Jun 10, 2020

For @aaronfranke, will do a 4.0 branch in a bit.

@fire
Copy link
Member Author

fire commented Jun 10, 2020

Test case: https://github.com/KhronosGroup/glTF-Sample-Models/tree/adf2abe718a61a6859b29fab481bfbbdfc05df24/2.0/Lights

@Calinou Calinou added this to the 3.2 milestone Jun 10, 2020
@fire
Copy link
Member Author

fire commented Jun 10, 2020

Error, spotlight is the one that needs the inner and outer definition not point light.

@aaronfranke aaronfranke mentioned this pull request Jun 11, 2020
Merged
@fire fire requested a review from clayjohn June 11, 2020 03:46
@aaronfranke @fire
[3.2] Add GLTF light import
e3cf64a 
Co-authored-by: K.S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
@aaronfranke aaronfranke changed the title Add gltf light import. [3.2] Add GLTF light import Jun 11, 2020
aaronfranke
aaronfranke approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my testing. See also #39450. Here is a screenshot of the test file in a 3.2 project: Screenshot from 2020-06-11 00-03-18

@akien-mga akien-mga merged commit 6c9b7c2 into godotengine:3.2 Jun 11, 2020
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the gltf-lights branch June 12, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
enhancement topic:import topic:3d
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fire @akien-mga @aaronfranke @Calinou