Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR fixes #40942. It's also related to #40943.
Summary
Malformed call expressions that create
GDScript::CallNode
instances withcallee == nullptr
are possible. An example of such a malformed expression isvar crash = ()(1)
. When these cases happen during editing, the editor crashes.The PR fixes the bug by:
GDScript::CallNode::get_callee_type
which checks fornullptr
and returnsType::NONE
in that case.Additionally, this PR adds a more descriptive error message when empty grouping expressions are encountered.