Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup fixes for X11 display server #41456

Merged
merged 4 commits into from Sep 2, 2020

Commits on Aug 22, 2020

  1. Re-apply "Fixes for windows in X11 tiling WMs"

    From PR godotengine#38727 which was reverted in godotengine#41373 because of regressions in Ubuntu
    with Gnome.
    
    Co-authored-by: Lorenzo Cerqua <lorenzocerqua@tutanota.com>
    pouleyKetchoupp and Lorenzo Cerqua committed Aug 22, 2020
    Copy the full SHA
    2b49cb0 View commit details
    Browse the repository at this point in the history
  2. Fix popup closed when an ancestor window is focused

    Previously, only the direct parent were taken into account.
    
    Popups like contextual menus could stay open if an ancestor which is
    not a direct parent was focused.
    
    Reproduction steps (any platform):
    - Select a node in the scene tree
    - Left click the node to start renaming
    - Right click to open the copy/paste contextual menu
    - Left click in the scene tree to deselect the node
    
    Also closing popup when focusing out of the application, without waiting
    for the parent to get focus to do so.
    pouleyKetchoupp committed Aug 22, 2020
    Copy the full SHA
    6d1ef8e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Fix menu popups delay and focus in X11 display server

    Now using override_redirect for menu & tooltip popups to prevent the WM from
    interfering with them, so we have more control over focus management
    and avoid a delay before they show up.
    pouleyKetchoupp committed Aug 26, 2020
    Copy the full SHA
    5315bff View commit details
    Browse the repository at this point in the history
  2. Fix WINDOW_EVENT_FOCUS_IN for popups on Windows

    On Windows, WINDOW_EVENT_FOCUS_IN was never sent by the display server
    for popups, because WM_ACTIVATE events are received during the call to
    _update_window_style, which happened before the callbacks were set.
    
    This was causing some issues with the way Popup is now handling closing on
    parent focus.
    
    Now _update_window_style is only called during show_window, after Window
    initialized callbacks.
    pouleyKetchoupp committed Aug 26, 2020
    Copy the full SHA
    bb30675 View commit details
    Browse the repository at this point in the history