Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger RigidBodyBullet space override updates when Area properties change. #42374

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

madmiraal
Copy link
Contributor

Currently, in Bullet physics, if an Area's properties change, any RigidBody that is already within the Area is not affected by the change.

This PR ensures that when the following Area properties are changed, the RigidBodies already enclosed in the Area are informed of the change and are updated accordingly:

  • The Gravity magnitude.
  • The Gravity direction Vector.
  • Whether or not the Area is a Gravity Point.
  • The Gravity Point location.
  • The Gravity Point fall-off Distance.
  • The Linear Damp
  • The Angular Damp

Fixes #32776

Registering changes to whether or not the Area is Monitoring or Monitorable is fixed with #42306.

Note: Changes to the Area's priority being ignored at runtime are not fixed with this PR or #42306.

@madmiraal madmiraal added bug topic:physics cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Sep 27, 2020
@madmiraal madmiraal added this to the 4.0 milestone Sep 27, 2020
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works fine on 3.x (can't be tested on master at the moment because Bullet is disabled).

@pouleyKetchoupp pouleyKetchoupp merged commit 0deccc5 into godotengine:master Nov 18, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 18, 2021
@madmiraal madmiraal deleted the fix-32776 branch November 19, 2021 07:46
madmiraal added a commit to madmiraal/godot that referenced this pull request Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bullet] Area Gravity issue
3 participants