Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Area3D audio_bus_name getter and setter #44260

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Rename Area3D audio_bus_name getter and setter #44260

merged 1 commit into from
Dec 10, 2020

Conversation

madmiraal
Copy link
Contributor

As identified in #29670, currently, unlike Area2D, Area3D's audio_bus_name's getter and setter are set_audio_bus and get_audio_bus.

This PR renames Area3D's:

  • set_audio_bus -> set_audio_bus_name
  • get_audio_bus -> get_audio_bus_name

Part of #16863.

@madmiraal madmiraal added this to the 4.0 milestone Dec 10, 2020
@madmiraal madmiraal requested a review from a team as a code owner December 10, 2020 10:11
@madmiraal madmiraal mentioned this pull request Dec 10, 2020
Closed
83 tasks
@akien-mga akien-mga merged commit d8fdb87 into godotengine:master Dec 10, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-area3d-audio_bus_name branch December 10, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:codestyle topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@madmiraal @akien-mga