Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AcceptDialog get_ok() to get_ok_button() #44389

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

madmiraal
Copy link
Contributor

As originally identified here, currently, WindowDialog has get_close_button(), but AcceptDialog has get_ok(), which returns the OK button and ConfirmationDialog has get_cancel(), which returns the Cancel button. Furthermore AcceptDialog has add_cancel(), which adds the Cancel button.

This PR renames:

  • AcceptDialog's get_ok() to get_ok_button()
  • AcceptDialog's add_cancel() to add_cancel_button()
  • ConfirmationDiaglog's get_cancel() to get_cancel_button()

Part of #16863.

Also renames:
- AcceptDialog add_cancel() to add_cancel_button()
- ConfirmationDiaglog get_cancel() to get_cancel_button()
@akien-mga akien-mga merged commit 93dbee9 into godotengine:master Dec 15, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants